Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to view platform specific configurations in once place #294

Open
3 tasks
StephenHodgson opened this issue Aug 16, 2019 · 12 comments
Open
3 tasks
Assignees
Labels
Feature Request FR Accepted Feature Request accepted, ready for development
Milestone

Comments

@StephenHodgson
Copy link
Member

StephenHodgson commented Aug 16, 2019

XRTK - Mixed Reality Toolkit Feature Request

Is your feature request related to a problem? Please describe

Users need a way to view all of the platform specific configurations in one place.

When platform level data provider configurations are changed from the default setting in the parent service level's configuration profile, then we should be properly supplying an "override" to that data provider with the setting.

The best example of this atm is the Spatial Awareness System and the WMR/Lumin data providers. There's global settings in the spatial awareness system that can be adjusted for all, then a per platform setting can also be supplied that will effectively override the global setting.

How would you classify your suggestion

  • Usability / Configuration
  • Architecture / Services

Acceptance Criteria

  • Developers can see per platform settings in one place.
  • Developers can set global settings for a service using it's configuration profile
  • Developers can set per platform settings using a data provider's configuration profile on the parent service.
@SimonDarksideJ
Copy link
Contributor

SimonDarksideJ commented Aug 19, 2019

My main issue with setting "Per Service" platform level overrides, is that you are taking an already heavy configuration layout and making it far more complicated.
Also if I want to look at the configuration for a single platform, I now have to hunt through each service to find the differences.

The approach in #290 is far simplier, by grouping each platforms config under a single header.
They can still share configuration, but allows the developer to customise a "Set" of config for a platform.

@StephenHodgson
Copy link
Member Author

You are setting a custom config per platform, on the data provider level.

The top down approach means that each master configuration can me wildly different than the per platform configuration.

@StephenHodgson
Copy link
Member Author

StephenHodgson commented Aug 19, 2019

I suppose it's simpler in the fact that you can easily see the changes, but it's more complex because of the vast differences you can have form one master configuration to another.

Where as the bottom up approach means that the platform is configured exactly as it should be and all the other settings are shared between all platform builds.

@SimonDarksideJ
Copy link
Contributor

Settings can still be shared between platforms, I would simply create folders for all my config. Putting the global (shared) config in one folder. Then creating platform variances only where I needed them

@StephenHodgson
Copy link
Member Author

Imho, it' simply a UX problem. But in reality we really need it to be this way from a arch standpoint.

We can easily make a window that shows just the specific platform settings.

@StephenHodgson
Copy link
Member Author

Putting the global (shared) config in one folder. Then creating platform variances only where I needed them

That's already the way it works

@SimonDarksideJ
Copy link
Contributor

Yes, except currently, there is no way to separate config per platform. Other than in the Data providers.
It's not available for the core services, etc.

@StephenHodgson
Copy link
Member Author

StephenHodgson commented Aug 19, 2019

Core system service profiles are the global shared config, and the data provider profiles are the per platform settings.

We just need a way to make this easier to access via UX updates.

@StephenHodgson
Copy link
Member Author

And make it more obvious that the data provider settings take precedent (even tho it may be the same options on the system level.

@StephenHodgson
Copy link
Member Author

StephenHodgson commented Aug 19, 2019

TL;DR I don't wanna change the way the whole xrtk fundamentally works, when it's just a UX problem.

@StephenHodgson StephenHodgson changed the title Provide adequate overrides to System settings on a per data provider level. Provide a way to view platform specific configurations in once place Aug 19, 2019
@SimonDarksideJ
Copy link
Contributor

Can you update the discussion in #290 and close this FR (since they are the same thing). Post your alternate proposal there.

@StephenHodgson
Copy link
Member Author

I just wanted to keep it clean by opening a new issue as an alt. Linked back here, just in case.

Is that okay?

@StephenHodgson StephenHodgson added the FR Under Review Feature request being reviewed label Aug 19, 2019
@StephenHodgson StephenHodgson added FR Accepted Feature Request accepted, ready for development and removed FR Under Review Feature request being reviewed labels Sep 16, 2019
@StephenHodgson StephenHodgson self-assigned this Sep 16, 2019
@StephenHodgson StephenHodgson added this to the Version 1.0.0 milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request FR Accepted Feature Request accepted, ready for development
Projects
None yet
Development

No branches or pull requests

2 participants