{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":2724167,"defaultBranch":"develop","name":"rippled","ownerLogin":"XRPLF","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2011-11-07T04:40:15.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/67929741?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714430674.0","currentOid":""},"activityList":{"items":[{"before":"a41720e92392d5e04302e810f97a767bff9ac6c7","after":"6974dfc6c2a7d17249b595477c39beceadca3a6a","ref":"refs/heads/update-maintainers","pushedAt":"2024-05-09T19:23:43.000Z","pushType":"push","commitsCount":59,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into update-maintainers","shortMessageHtmlLink":"Merge branch 'develop' into update-maintainers"}},{"before":"f6509495731b396ce33d96778e8df0366a8200bf","after":"f4da2e31d93e921f1742a6c7c2120409cba4810e","ref":"refs/heads/develop","pushedAt":"2024-05-09T19:17:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Price Oracle: validate input parameters and extend test coverage: (#5013)\n\n* Price Oracle: validate input parameters and extend test coverage:\r\n\r\nValidate trim, time_threshold, document_id are valid\r\nInt, UInt, or string convertible to UInt. Validate base_asset\r\nand quote_asset are valid currency. Update error codes.\r\nExtend Oracle and GetAggregatePrice unit-tests.\r\nDenote unreachable coverage code.\r\n\r\n* Set one-line LCOV_EXCL_LINE\r\n\r\n* Move ledger_entry tests to LedgerRPC_test.cpp\r\n\r\n* Add constants for \"None\"\r\n\r\n* Fix LedgerRPC test\r\n\r\n---------\r\n\r\nCo-authored-by: Scott Determan ","shortMessageHtmlLink":"Price Oracle: validate input parameters and extend test coverage: (#5013"}},{"before":"76128051c08b4038455edfa5f5acc9a1d31e8ba5","after":"f6509495731b396ce33d96778e8df0366a8200bf","ref":"refs/heads/develop","pushedAt":"2024-05-02T19:44:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Add external directory to Conan recipe's exports (#5006)","shortMessageHtmlLink":"Add external directory to Conan recipe's exports (#5006)"}},{"before":"5aa1106ba1fe25ee26dae34feeeed2136ba21bd7","after":"76128051c08b4038455edfa5f5acc9a1d31e8ba5","ref":"refs/heads/develop","pushedAt":"2024-05-02T15:14:59.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Add missing includes (#5011)","shortMessageHtmlLink":"Add missing includes (#5011)"}},{"before":"7ac63cd2aa0b53662cef05ab2e9dca2baf4a8c31","after":"3ba4f193c26e270d4f8c8957bdab874d194892b9","ref":"refs/heads/fix-4020","pushedAt":"2024-05-01T17:43:55.000Z","pushType":"push","commitsCount":68,"pusher":{"login":"intelliot","name":"Elliot Lee","path":"/intelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/81505?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into fix-4020","shortMessageHtmlLink":"Merge branch 'develop' into fix-4020"}},{"before":"dccf3f49ef35bedef76dd93e14fd071e34cd7f58","after":"5aa1106ba1fe25ee26dae34feeeed2136ba21bd7","ref":"refs/heads/develop","pushedAt":"2024-05-01T17:27:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"Remove flow assert: (#5009)\n\nRounding in the payment engine is causing an assert to sometimes fire\nwith \"dust\" amounts. This is causing issues when running debug builds of\nrippled. This issue will be addressed, but the assert is no longer\nserving its purpose.","shortMessageHtmlLink":"Remove flow assert: (#5009)"}},{"before":"67286068ffe525d8dd3b96a8b989a413f2f71024","after":null,"ref":"refs/heads/nbougalis-patch-1","pushedAt":"2024-04-29T22:44:34.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"}},{"before":"02ec8b7962bfc1e046b85ab9414cfcf08be072b9","after":"dccf3f49ef35bedef76dd93e14fd071e34cd7f58","ref":"refs/heads/develop","pushedAt":"2024-04-29T22:44:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Update list of maintainers: (#4984)\n\nI am resigning from my role as maintainer of the `rippled` codebase.\r\n\r\nPlease update repository permissions accordingly, prior to merging this pull request.\r\n\r\nThanks to everyone who has contributed, especially those whom I had the opportunity to closely collaborate with.","shortMessageHtmlLink":"Update list of maintainers: (#4984)"}},{"before":"0fdb29be9bb9a4785a41d2d8727fcf40ddc24a1c","after":"67286068ffe525d8dd3b96a8b989a413f2f71024","ref":"refs/heads/nbougalis-patch-1","pushedAt":"2024-04-29T18:20:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into nbougalis-patch-1","shortMessageHtmlLink":"Merge branch 'develop' into nbougalis-patch-1"}},{"before":"676aae2755d0063cddce5bc4cd76bdccd55dd28c","after":"02ec8b7962bfc1e046b85ab9414cfcf08be072b9","ref":"refs/heads/release","pushedAt":"2024-04-26T23:00:49.000Z","pushType":"push","commitsCount":16,"pusher":{"login":"intelliot","name":"Elliot Lee","path":"/intelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/81505?s=80&v=4"},"commit":{"message":"Set version to 2.2.0-rc1","shortMessageHtmlLink":"Set version to 2.2.0-rc1"}},{"before":"3f7ce939c8cdea08d4161762e5d2a8d9d93c6790","after":"02ec8b7962bfc1e046b85ab9414cfcf08be072b9","ref":"refs/heads/develop","pushedAt":"2024-04-26T22:52:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Set version to 2.2.0-rc1","shortMessageHtmlLink":"Set version to 2.2.0-rc1"}},{"before":"777fb734c4ca50da32e46c2740ebe9aaca306593","after":"0fdb29be9bb9a4785a41d2d8727fcf40ddc24a1c","ref":"refs/heads/nbougalis-patch-1","pushedAt":"2024-04-26T02:06:44.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into nbougalis-patch-1","shortMessageHtmlLink":"Merge branch 'develop' into nbougalis-patch-1"}},{"before":"b422e71eed41d0c4c0ad93a90f51599185a67a61","after":"3f7ce939c8cdea08d4161762e5d2a8d9d93c6790","ref":"refs/heads/develop","pushedAt":"2024-04-26T01:15:19.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"seelabs","name":"Scott Determan","path":"/seelabs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5853458?s=80&v=4"},"commit":{"message":"fix amendment: AMM swap should honor invariants: (#5002)\n\nThe AMM has an invariant for swaps where:\nnew_balance_1*new_balance_2 >= old_balance_1*old_balance_2\n\nDue to rounding, this invariant could sometimes be violated (although by\nvery small amounts).\n\nThis patch introduces an amendment `fixAMMRounding` that changes the\nrounding to always favor the AMM. Doing this should maintain the\ninvariant.\n\nCo-authored-by: Bronek Kozicki\nCo-authored-by: thejohnfreeman","shortMessageHtmlLink":"fix amendment: AMM swap should honor invariants: (#5002)"}},{"before":"959cd242d7fcf838e78e8ff48a9e9ec6e9106f22","after":"777fb734c4ca50da32e46c2740ebe9aaca306593","ref":"refs/heads/nbougalis-patch-1","pushedAt":"2024-04-25T23:07:51.000Z","pushType":"push","commitsCount":22,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into nbougalis-patch-1","shortMessageHtmlLink":"Merge branch 'develop' into nbougalis-patch-1"}},{"before":"e9859ac1b16f8ab275955e89c05108f366327fd4","after":"b422e71eed41d0c4c0ad93a90f51599185a67a61","ref":"refs/heads/develop","pushedAt":"2024-04-25T17:05:12.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"thejohnfreeman","name":"John Freeman","path":"/thejohnfreeman","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1133852?s=80&v=4"},"commit":{"message":"chore: fix typos (#4958)","shortMessageHtmlLink":"chore: fix typos (#4958)"}},{"before":"b84f7e7c1022df82da33cc5db39632c3e2be44b2","after":"e9859ac1b16f8ab275955e89c05108f366327fd4","ref":"refs/heads/develop","pushedAt":"2024-04-24T17:54:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"test: Add RPC error checking support to unit tests (#4987)","shortMessageHtmlLink":"test: Add RPC error checking support to unit tests (#4987)"}},{"before":"676aae2755d0063cddce5bc4cd76bdccd55dd28c","after":"b84f7e7c1022df82da33cc5db39632c3e2be44b2","ref":"refs/heads/develop","pushedAt":"2024-04-19T18:41:33.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"thejohnfreeman","name":"John Freeman","path":"/thejohnfreeman","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1133852?s=80&v=4"},"commit":{"message":"Ignore more commits","shortMessageHtmlLink":"Ignore more commits"}},{"before":"f20e66e6f97907ef740dc3f20b425be2dbbecf6e","after":"676aae2755d0063cddce5bc4cd76bdccd55dd28c","ref":"refs/heads/develop","pushedAt":"2024-04-19T16:21:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Set version to 2.2.0-b3","shortMessageHtmlLink":"Set version to 2.2.0-b3"}},{"before":"c88166e055e4378f78fb0236e0bf347d6544e517","after":"676aae2755d0063cddce5bc4cd76bdccd55dd28c","ref":"refs/heads/release","pushedAt":"2024-04-19T16:21:05.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Set version to 2.2.0-b3","shortMessageHtmlLink":"Set version to 2.2.0-b3"}},{"before":"cd737ad7d31be228b00d81c7ad121b6fbcbb00ce","after":"f20e66e6f97907ef740dc3f20b425be2dbbecf6e","ref":"refs/heads/develop","pushedAt":"2024-04-19T01:09:25.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"fix: Remove redundant STAmount conversion in test (#4996)","shortMessageHtmlLink":"fix: Remove redundant STAmount conversion in test (#4996)"}},{"before":"df3aa8452387b8009f724f8852b48708e873c819","after":"cd737ad7d31be228b00d81c7ad121b6fbcbb00ce","ref":"refs/heads/develop","pushedAt":"2024-04-18T20:45:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"fix: resolve database deadlock: (#4989)\n\nThe `rotateWithLock` function holds a lock while it calls a callback\r\nfunction that's passed in by the caller. This is a problematic design\r\nthat needs to be used very carefully. In this case, at least one caller\r\npassed in a callback that eventually relocks the mutex on the same\r\nthread, causing UB (a deadlock was observed). The caller was from\r\nSHAMapStoreImpl, and it called `clearCaches`. This `clearCaches` can\r\npotentially call `fetchNodeObject`, which tried to relock the mutex.\r\n\r\nThis patch resolves the issue by changing the mutex type to a\r\n`recursive_mutex`. Ideally, the code should be rewritten so it doesn't\r\nhold the mutex during the callback and the mutex should be changed back\r\nto a regular mutex.\r\n\r\nCo-authored-by: Ed Hennis ","shortMessageHtmlLink":"fix: resolve database deadlock: (#4989)"}},{"before":"24a275ba25770df0819fedba7c576ddc1c42bb0e","after":"df3aa8452387b8009f724f8852b48708e873c819","ref":"refs/heads/develop","pushedAt":"2024-04-18T20:15:31.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"test: verify the rounding behavior of equal-asset AMM deposits (#4982)\n\n* Specifically, test using tfLPToken flag","shortMessageHtmlLink":"test: verify the rounding behavior of equal-asset AMM deposits (#4982)"}},{"before":"aae438315f08a6d1766a43ee0c0d724d1d9cba5b","after":"24a275ba25770df0819fedba7c576ddc1c42bb0e","ref":"refs/heads/develop","pushedAt":"2024-04-18T19:25:22.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"test: Add tests to raise coverage of AMM (#4971)\n\n---------\r\n\r\nCo-authored-by: Howard Hinnant \r\nCo-authored-by: Mark Travis \r\nCo-authored-by: Bronek Kozicki \r\nCo-authored-by: Mayukha Vadari \r\nCo-authored-by: Chenna Keshava ","shortMessageHtmlLink":"test: Add tests to raise coverage of AMM (#4971)"}},{"before":"8b0d049b9f0d0612b5fef019d48b5b089c653933","after":"aae438315f08a6d1766a43ee0c0d724d1d9cba5b","ref":"refs/heads/develop","pushedAt":"2024-04-18T17:21:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"chore: Improve codecov coverage reporting (#4977)\n\n* Amend `.codecov.yml` to disable coverage reporting of test sources\r\n and explicitly set most parameters\r\n* Increase codecov upload retry time to 210s (from 35s)\r\n* Upgrade gcovr adding support for more coverage formats (lcov, clover, jacoco)\r\n* Upgrade github actions in coverage workflow\r\n* Explicitly disable codecov plugins (also removing `gcov` coverage, which is not\r\n correctly handled by codecov https://github.com/codecov/feedback/issues/334)","shortMessageHtmlLink":"chore: Improve codecov coverage reporting (#4977)"}},{"before":"659bd99a6708af9da9b61a59dc6badb18024180f","after":"8b0d049b9f0d0612b5fef019d48b5b089c653933","ref":"refs/heads/develop","pushedAt":"2024-04-18T16:30:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"test: Unit test for AMM offer overflow (#4986)","shortMessageHtmlLink":"test: Unit test for AMM offer overflow (#4986)"}},{"before":"c88166e055e4378f78fb0236e0bf347d6544e517","after":"659bd99a6708af9da9b61a59dc6badb18024180f","ref":"refs/heads/develop","pushedAt":"2024-04-18T14:41:25.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"fix amendment to add `PreviousTxnID`/`PreviousTxnLgrSequence` (#4751)\n\nThis amendment, `fixPreviousTxnID`, adds `PreviousTxnID` and\r\n`PreviousTxnLgrSequence` as fields to all ledger objects that did\r\nnot already have them included (`DirectoryNode`, `Amendments`,\r\n`FeeSettings`, `NegativeUNL`, and `AMM`). This makes it much easier\r\nto go through the history of these ledger objects.","shortMessageHtmlLink":"fix amendment to add PreviousTxnID/PreviousTxnLgrSequence (#4751)"}},{"before":null,"after":"959cd242d7fcf838e78e8ff48a9e9ec6e9106f22","ref":"refs/heads/nbougalis-patch-1","pushedAt":"2024-04-10T17:03:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"nbougalis","name":"Nik Bougalis","path":"/nbougalis","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5085415?s=80&v=4"},"commit":{"message":"Update list of maintainers:\n\nI am resigning from my role as maintainer of the `rippled` codebase.\r\n\r\nPlease update repository permissions accordingly, prior to merging this pull request.\r\n\r\nThanks to everyone who has contributed, especially those whom I had the opportunity to closely collaborate with.","shortMessageHtmlLink":"Update list of maintainers:"}},{"before":"97863e0b626aa34d6cba09a7074b7f6c08832f48","after":"c88166e055e4378f78fb0236e0bf347d6544e517","ref":"refs/heads/release","pushedAt":"2024-04-05T17:49:18.000Z","pushType":"push","commitsCount":27,"pusher":{"login":"intelliot","name":"Elliot Lee","path":"/intelliot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/81505?s=80&v=4"},"commit":{"message":"Set version to 2.2.0-b2","shortMessageHtmlLink":"Set version to 2.2.0-b2"}},{"before":"c187f750fe7117ebd219e50743bf19d07aa44951","after":"c88166e055e4378f78fb0236e0bf347d6544e517","ref":"refs/heads/develop","pushedAt":"2024-04-05T13:10:06.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"Set version to 2.2.0-b2","shortMessageHtmlLink":"Set version to 2.2.0-b2"}},{"before":"bcbf6c1973ff4bc7695dab7680071e3aab424405","after":"c187f750fe7117ebd219e50743bf19d07aa44951","ref":"refs/heads/develop","pushedAt":"2024-04-04T14:40:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ximinez","name":"Ed Hennis","path":"/ximinez","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6757714?s=80&v=4"},"commit":{"message":"chore: Default validator-keys-tool to master branch: (#4943)\n\n* master is the default branch for that project. There's no point in\r\n using develop.","shortMessageHtmlLink":"chore: Default validator-keys-tool to master branch: (#4943)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAERe__dQA","startCursor":null,"endCursor":null}},"title":"Activity ยท XRPLF/rippled"}