-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Back to waypoints list after watching waypoint details #620
Comments
Please provide a PR. |
Sorry @lordfolken but it doesn't seems simple enough to me (or at least some guidance will be required) I noticed the XCSoar/src/Dialogs/Waypoint/dlgWaypointDetails.cpp Lines 439 to 440 in c1b2909
but I'm pretty sure some changes are also required on the "caller" side XCSoar/src/Dialogs/Waypoint/WaypointList.cpp Lines 228 to 230 in c1b2909
|
I've created a commit for this that...works, but feels like a bit of a hack. It is also perhaps incomplete because I think the Alternates dialog could benefit from having the same behavior. HeroicLemon@82fc215 I am also wondering if this could potentially break a user's existing .xci file somehow. I don't think changing the behavior like this would cause problems, but I also do not have a good feel for what sorts of things a user is able to do with the custom inputs yet. Should something like InputEvents::eventWaypointDetailsPersistent be created in order to ensure that past behavior is maintained? |
Please create a PR and set it to draft. Then it runs through our qa and testing stage, and we can have a discussion on the topic. |
It is debatable whether this is a good idea. I don't think it is. If you just want to look up a waypoint and inspect it, you then need an extra click to return to the map. |
I have created the draft PR as requested #749
A good point. On my last flight, I had actually been attempting to look at the details for multiple waypoints and found the current implementation a little annoying before I even saw this issue on GitHub, but if I did just want to look at the details for a single waypoint it could also be annoying to have to click twice to get back to my main view. Adding a separate InputEvent could allow a user to decide how their dialog behaved, but I would suspect many users don't make use of that feature? |
Hello,
XCSoar version
I'm using XCSoar 7.6
What should XCSoar do differently, what functionality should be added?
After seeing waypoints list to watch distance of several waypoints, I want to have more information about some specific waypoints (such as required glide ratio).
So I can select one and look for data such as required glide ratio or Alt diff MC safety.
Unfortunately when clicking on "close" button... it's getting back to map page... not waypoint lists which is not very convenient.... especially when considering several waypoints options.
Similar problem also occurs when using Nav / Alternates window
Changing (in such a context "Close" button to a "Back" button... which turn back to waypoints list will be a nice feature to have
What are you trying to do, what is the use case for the suggestion?
Waypoint details page should store the context of the "previous" page which was used to display waypoint details.
If it's waypoints list or alternates, close button should be turned to a back button to get back to either waypoints list or alternates list.
The text was updated successfully, but these errors were encountered: