Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call BuildServiceProvider in UseFreshMvvm #1

Open
ggutschi opened this issue Jan 11, 2022 · 1 comment
Open

Do not call BuildServiceProvider in UseFreshMvvm #1

ggutschi opened this issue Jan 11, 2022 · 1 comment

Comments

@ggutschi
Copy link

Hi!

The call of BuildServiceProvider in UseFreshMvvm is bad practice (see Microsoft Docs).
For example: Nested constructor injections with singletons won't work.

Best regards

@ggutschi
Copy link
Author

As a workaround I'm using

var app = builder.Build();

DependancyService.RegisterServiceProvider(app.Services.GetService<IServiceProvider>());

return app;

instead of

services.UseFreshMvvm();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant