Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unidentified Shiny Items are not annotated correctly #2488

Closed
ShadowCat117 opened this issue May 13, 2024 · 1 comment · Fixed by #2503
Closed

Unidentified Shiny Items are not annotated correctly #2488

ShadowCat117 opened this issue May 13, 2024 · 1 comment · Fixed by #2503
Labels
All mod loaders bug Something isn't working confimed

Comments

@ShadowCat117
Copy link
Contributor

GearItem currently expects the shiny symbol to be before the "Unidentified".

image
@kristofbolyai
Copy link
Collaborator

I may take a look into this later.

kristofbolyai added a commit that referenced this issue May 15, 2024
@kristofbolyai
fix: Parse unidentified shiny items correctly [skip ci]
415f558 
I think this is all we need to fix #2488.
@kristofbolyai kristofbolyai mentioned this issue May 15, 2024
Merged
kristofbolyai added a commit that referenced this issue May 15, 2024
@kristofbolyai
fix: Parse unidentified shiny items correctly [skip ci]
cdba893 
I think this is all we need to fix #2488.
github-merge-queue bot pushed a commit that referenced this issue May 16, 2024
@kristofbolyai
fix: Parse unidentified shiny items correctly [skip ci] (#2503)
1bec7fe 
* fix: Parse unidentified shiny items correctly [skip ci]

I think this is all we need to fix #2488.

* fix: Better regex

* chore: add tests

* chore: add test in text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
All mod loaders bug Something isn't working confimed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Parse unidentified shiny items correctly [skip ci] Wynntils/Artemis
2 participants
@ShadowCat117 @kristofbolyai