Allow loading some resource packs ONLY when joining wynncraft

[MenacingPerson]

For example, some packs like the Fungal Pack, Smaller Meteors/Ice Snake, Dark Mode GUI, etc

It would be a setting in wynntils that loads these alongside the wynncraft resource pack, and also hopefully on top of it.

The purpose is that they won't be loaded when not on wynncraft, as some like fungal pack can break other servers.

Using Wynntils auto-apply RPs, it would apply them on top of the wynntils one, which is not even possible using other mods currently.

[geekazodium]

how do you suggest this work, my current idea is to just add a button to the texturepacks when displayed in the menu that allow you to toggle if a texturepack should only load if you are on wynncraft.
I'm suggesting something like this: (white shaded areas are where the buttons will appear)

[geekazodium]

alternative idea is to have text on one of the corners of the screen saying shift-click to make texturepack wynncraft only and shade in the texturepack you are hovering your cursor over be highlighted differently when you hold shift, and when a texture pack is toggled to wynncraft only it would show up with a different background color.

[magicus]

Is this a feature request to basically "bundle" a bunch of other local resource pack that should be applied at the same time as the Wynncraft resource pack? Either when the server asks you to install the pack upon joining, or when you load Minecraft (if you have the load resource pack on start feature enabled)?

[MenacingPerson]

Is this a feature request to basically "bundle" a bunch of other local resource pack that should be applied at the same time as the Wynncraft resource pack?

Yes, exactly

But it applies them above the wynntils/wynncraft texture pack, so that the wynncraft textures can be overriden by the local resource packs

my current idea is to just add a button to the texturepacks when displayed in the menu that allow you to toggle if a texturepack should only load if you are on wynncraft.

why a button? A config in the wynntils book should be enough, right?

[geekazodium]

why a button? A config in the wynntils book should be enough, right?

I was suggesting a an option in the texture packs menu as that would be where you would configure texture packs anyways.

however adding a config in the wynntils book is also fine, I don't know which idea would be better. (personally I'd prefer navigating this in the resourcepacks menu, as I don't quite like navigating the wynntils book in general but that's just me.)

[MenacingPerson]

I don't really care either way as long as the functionality is there. Thank you if you choose to implement it.

[magicus]

There is no need for button at all, I think. The way we could implement this is that you activate all resource packs that you want, and then we need to have a way to "save the state", and then we'll restore the set of resource packs you have active, instead of just the Wynn one.

This is not trivial to fix, but it's not impossible either.

[MenacingPerson]

Saving the state is already done in options.txt. Why can't that just be copied over separately into a wynntils file?

Also there's an issue with this, you can't put any packs above the wynntils ones.

[geekazodium]

There is no need for button at all, I think. The way we could implement this is that you activate all resource packs that you want, and then we need to have a way to "save the state", and then we'll restore the set of resource packs you have active, instead of just the Wynn one.

This is not trivial to fix, but it's not impossible either.

so if I understand correctly, we save resourcepack configuration for wynncraft separately from the resourcepack configuration everywhere else?

[magicus]

I just threw out a vague sketch of how I would resolve this, without having to get into tricky GUI situations, and that was to ask the player to setup the resource packs they want, and in the order they want, and then hit "save" in Wynntils, and then we'd restore those resource packs in that order when connecting to Wynncraft.

If that was not was requested, apologies for misunderstanding.

[geekazodium]

I mean the simplest implementation would be to modify any attempt at accessing this value with a check for if you are on wynncraft, and return a different instance if you are on wynncraft, and then like if you are on the title screen provide a new button to open configuration for wynncraft resource packs.
(need to do some testing to make sure)

[geekazodium]

yep this idea should in theory work.

[geekazodium]

Hi, sorry about the time this is taking, I'm still really new to contributing and I have no idea what I'm doing, I'll try my best to complete this as soon as possible, I'm extremely sorry about the wait.

For example, some packs like the Fungal Pack, Smaller Meteors/Ice Snake, Dark Mode GUI, etc

It would be a setting in wynntils that loads these alongside the wynncraft resource pack, and also hopefully on top of it.

The purpose is that they won't be loaded when not on wynncraft, as some like fungal pack can break other servers.

Using Wynntils auto-apply RPs, it would apply them on top of the wynntils one, which is not even possible using other mods currently.

@MenacingPerson

please forgive me I have definitely overcomplicated this in my head and spent too long.
I'm a bit slow sometimes.

[MenacingPerson]

I'm extremely sorry about the wait.
please forgive me I have definitely overcomplicated this in my head and spent too long.
I'm a bit slow sometimes.

Please don't beat yourself up over this. I appreciate the work that you and other wynntils devs are doing. Thank you for what you do.

@geekazodium

[geekazodium]

hi, I'd like to update ya on the fact that the part about getting texturepacks to have higher priority than wynncraft textures is done, I need to polish it a little bit but @MenacingPerson what are your thoughts to making that part the changes to be part of the auto apply resourcepack feature?

[geekazodium]

and yeah I think I learned something important today about not overcomplicating things, I uhhmmm.... whoops. (I'm still new to contributing, sorry about that :3)

[geekazodium]

I'll start redoing my spaghetti code for the other part of the suggested feature, hopefully I don't get overwhelmed this time and ghost everyone for a few months again

[MenacingPerson]

I feel like it could be:

1. Specify the pack order somewhere (hopefully a nice and clear UI; but the wynntils devs can definitely help you here maybe?)
   • A button in the resource packs menu when in wynncraft would be nice
2. Have it apply them alongside the server resource pack when joining wynn OR the game itself when auto-apply resource pack is enabled

• Also, generally you need to apply the wynncraft packs above the wynn default one, but could it also be possible to apply them below the wynn one?
  • This has a usecase where some packs might break a texture or two if you apply them above the wynncraft one, but perhaps you don't want to use them outside of wynn

But of course if this is too difficult, you can drop this one, this isn't that necessary ^
And by "below the wynn one" I mean packs could be in any pack order that's preferred by the user as opposed to only above the wynncraft server pack.
Is that possible?

[geekazodium]

I think that it would probably be easier for now to just make it possible to move the wynntils resource packs down on the resource pack list, to enable loading packs on top of it, and then add something that automatically loads certain packs only when joining wynncraft.