Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deny button #20

Closed
wants to merge 1 commit into from
Closed

Add deny button #20

wants to merge 1 commit into from

Conversation

Xenorio
Copy link

@Xenorio Xenorio commented Dec 14, 2020

Should be backwards compatible.

Adds a button for denying cookies, which sets the acceptCookies cookie to false instead of true.

If acceptCookies is undefined, the alert will show as usual. If it's either true or false, it won't.

Also implements an event that fires when the deny button is clicked.

Partially fixes #19

Should be backwards compatible
@trevismd
Copy link

Hey,
Nice and clean.
However, is it appropriate to just set a cookie for 1 year after someone chose "decline"? I think most sites keep coming at you at nexts visits in theses cases. Or there should be multiple levels of (dis-)agreement...

@Xenorio
Copy link
Author

Xenorio commented May 21, 2021

If you don't want the information to be saved, you can just not add the button. Of course setting a cookie that stores your choice not to use cookies is kind of counter intuitive, but that information needs to be saved somewhere if you don't want to keep bothering users with the popup. And it's not like there's any identifying information in there, just a boolean. So it counts as a purely functional cookie with no tracking capability or something similar, which in my mind is completely okay data-protection wise and should be covered by most (if not all) international laws regarding cookies (i am not a lawyer tho)

Anyway, this was just a modification i made for personal purposes and thought i might as well share in case someone else wants the same functionality.

@Xenorio
Copy link
Author

Xenorio commented Mar 9, 2022

Well apparently this is dead, sooo...

@Xenorio Xenorio closed this Mar 9, 2022
@trevismd
Copy link

trevismd commented Mar 9, 2022

That's too bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "deny" button (alongside learn more)
2 participants