Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make moon orbits in solar system view independent of planet orbits #235

Open
patudom opened this issue Jul 21, 2019 · 4 comments
Open

Make moon orbits in solar system view independent of planet orbits #235

patudom opened this issue Jul 21, 2019 · 4 comments

Comments

@patudom
Copy link

patudom commented Jul 21, 2019

Sometimes it is useful to show only the Moon's orbit, without showing orbits of all the planets in the background. Currently, the Moon orbits only display when the planet orbits are displayed. Can this be changed, so we can toggle the orbits on/off independently?

@pkgw
Copy link
Contributor

pkgw commented Jul 25, 2019

This is a pretty specialized use case, so I have trouble seeing it be something we'd prioritize. I guess the workaround would be to turn off all satellite orbits, and then add a special orbit layer corresponding to the Moon?

@patudom
Copy link
Author

patudom commented Aug 12, 2019

It seems like it's just a logic on/off thing, so shouldn't it be pretty straightforward to rewire?

Actually, I'm noticing different behaviors in the web and desktop client, and unless there is a compelling reason, I think they should behave in the same way to avoid confusion.

Desktop client:

  • Planet orbits and moon/satellite orbits for everything besides Earth's moon are independent. (You can turn off planet orbits while looking at orbits of moons of non-Earth planets. This seems like an oversight because "planet orbits" in the past also gave us our moon's orbit. When the other planets' moons were added later, we probably should have moved control of Earth's moon to the "moon & satellite orbits" button, but that was never done and it may be confusing to change it now).

Web client:

  • You cannot turn on moon/satellite orbits unless planet orbits are already on. The behavior should be changed to match the desktop client.

@patudom
Copy link
Author

patudom commented Aug 12, 2019

(Agree it's not a super urgent/high priority. Just trying to be in the habit of documenting when I notice behaviors that could be improved).

@pkgw
Copy link
Contributor

pkgw commented Aug 22, 2019

@patudom Thanks for documenting in detail, it's definitely very helpful to have things written down! My hesitation was because I thought this was calling for new UI toggles, which I prefer to avoid since our UI is so complex already, but it sounds like all the checkboxes are there already, so they might as well work right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants