Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Table Design #1908

Open
2 tasks done
msaini888 opened this issue Jan 1, 2021 · 6 comments
Open
2 tasks done

Responsive Table Design #1908

msaini888 opened this issue Jan 1, 2021 · 6 comments
Labels
needs:discussion More discussion and consensus is needed before PR can be merged or work can be done needs:triage New issue that needs triage P2 "Nice to have" - shipping next version without this will not have a major impact source:qa From QA team

Comments

@msaini888
Copy link

msaini888 commented Jan 1, 2021

Some of the screens of the application are not adjusting well when the app is being run on bigger screen size android tablet

The below screens are not adapting well for “Tablet Responsive Design” according to me :
1.Onboarding Screen - get the latest news from your community
2.Onboarding Screen - Allow Notifications
3.Get The Facts - All Individual screens of this section when we expand the text then there is big large empty white space on all of these screens, ideally the text should be resized to take up the screen size appropriately.
4.Home Screen Footer Icons Size looks a bit small for the tablet screen size

System

  • Device: Samsung Galaxy Tab S4 10.5
  • OS: Android 10.0
  • App Version: 1.0.0 Staging(281)

Screenshots

Samsung Galaxy Tab Onboarding Screen1

OnboardingScreen1

Samsung Galaxy Tab Onboarding Screen2

2020-12-21T15_07_06 156Z_mohit020888_COVID-19_EU_Samsung_Galaxy_Tab_S4_10_5_real_10

Samsung Galaxy Tab Get The Facts Screen

2020-12-21T15_13_59 055Z_mohit020888_COVID-19_EU_Samsung_Galaxy_Tab_S4_10_5_real_10

Samsung Galaxy Tab Home Screen Footer Icons

2020-12-21T15_08_17 287Z_mohit020888_COVID-19_EU_Samsung_Galaxy_Tab_S4_10_5_real_10

Checklist:

@msaini888 msaini888 added needs:triage New issue that needs triage source:public Issues created by the public needs:discussion More discussion and consensus is needed before PR can be merged or work can be done P2 "Nice to have" - shipping next version without this will not have a major impact source:qa From QA team and removed source:public Issues created by the public labels Jan 1, 2021
@theswerd
Copy link
Collaborator

One fix for the homepage could be setting a max height on each of the Protect Yourself cards.

@Mohit020888 What do you think?

@msaini888
Copy link
Author

@theswerd - Yes as long as that fix takes care of the automatic text resizing according to different screen sizes then it should be good.
What about the footer icons?
Do we need fresh set of bigger image icons for them or are they okay according to you?

@theswerd
Copy link
Collaborator

@Mohit020888 - I have trouble seeing an easy fix to the bottom icons. We are using the iOS standard bottom tab bar, to make the bottom icons larger we would have to create our own custom one.

@theswerd
Copy link
Collaborator

@Mohit020888 it looks like some designs center the tab bar items - would that be better?

@msaini888
Copy link
Author

msaini888 commented Jan 14, 2021

@Mohit020888 - I have trouble seeing an easy fix to the bottom icons. We are using the iOS standard bottom tab bar, to make the bottom icons larger we would have to create our own custom one.

@theswerd -I think if that's the case then creating a custom bar would require significant coding effort so I think we should not get into that as of now.

@msaini888
Copy link
Author

@Mohit020888 it looks like some designs center the tab bar items - would that be better?

@theswerd - the alignment of footer icons seems okay to me so I would request you to focus on other high priority tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:discussion More discussion and consensus is needed before PR can be merged or work can be done needs:triage New issue that needs triage P2 "Nice to have" - shipping next version without this will not have a major impact source:qa From QA team
Projects
None yet
Development

No branches or pull requests

2 participants