Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite Session Enhancement #1309

Open
renintw opened this issue May 2, 2024 · 1 comment
Open

Favorite Session Enhancement #1309

renintw opened this issue May 2, 2024 · 1 comment
Labels
[Component] Blocks All custom blocks (Speakers, CrowdCast, Live Schedule, etc) [Type] Bug [Type] Enhancement [Type] Feature Request [Type] Story Composed of multiple features, enhancements, or bug fixes that deliver clear user value

Comments

@renintw
Copy link
Contributor

renintw commented May 2, 2024

Description

It's a great feature to add favorite sessions and send them as an email because often there is a period between when the schedule is released and the actual event day. On the event day, I often find that many people forget which sessions they were interested in at that time, and they have to browse through them again. However, I don't think many people are aware of this feature. On some sites, the star is even used as a decoration, or the 'send to email' widget is completely missing, or the UI is broken.

Here are a few ideas:

  1. Improve the design of the stars: They could be hollow; currently, they are gray, but on some sites, they turn blue, which often makes them seem decorative.
  2. Improve the UI of the widget:
    • Maybe displaying the user's selected favorite sessions can be one of the functions?
    • Show the actual reason for email failures (currently, it only shows 'send fail'), such as the event has ended, or you have not selected any sessions yet.
    • Make the widget's appearance more attractive and noticeable, maybe consider making the overall design to be more modern.
    • [Bug] Email with trailing space should be properly handled.
    • [Bug] On some sites (WCEU for example), it doesn't seem to work correctly.

Screenshots / Screencasts

Add favorite sessions
favorite

Failure message isn't clear enough
Screenshot 2024-05-02 at 15 48 00

Stakeholders

WordCamp Attendees.

How does this new feature contribute to the objectives

Is this a feature that people need? I believe so, but perhaps not a high-priority one.
Can it truly achieve your desired outcomes? I think so, it makes it more convenient for attendees, I think this is also one of the reasons why the feature to add favorite sessions was implemented initially.

Acceptance Criteria

Pending discussion.

Priority

Pending discussion.

@renintw renintw added [Component] Blocks All custom blocks (Speakers, CrowdCast, Live Schedule, etc) [Type] Feature Request [Type] Enhancement [Type] Bug labels May 2, 2024
@ciudadanoB
Copy link

Hi @renintw!

Regarding the bug in WCEU site (and others) where it seems that this is not working correctly, it's just a cosmetic thing. Right now you can select some sessions and although the star goes back to grey, if you print your favorite sessions, they all appear.

So it's a CSS thing. If in the file favorite-sessions.css, line 93 you add this second element, they'll appear in yellow correctly:

td.wcb-favourite-session a.fav-session-button,
.wcb-favourite-session .wcb-session-favourite-icon a.fav-session-button {
	color: #ffb900;
}

Now, with this it works, but when you try to deselect one, it keeps the yellow color as it's in the :focus state. I've added some lines to make it work a little better when hovering and focusing that button:

td.wcb-favourite-session a.fav-session-button,
.wcb-favourite-session .wcb-session-favourite-icon a.fav-session-button,
.wordcamp-schedule div.wcb-session-favourite-icon a.fav-session-button:hover,
.wordcamp-schedule div.wcb-session-favourite-icon a.fav-session-button:focus:hover,
.wordcamp-schedule .wcb-favourite-session div.wcb-session-favourite-icon a.fav-session-button:focus {
	color: #ffb900;
}

.wordcamp-schedule .wcb-favourite-session div.wcb-session-favourite-icon a.fav-session-button:hover,
.wordcamp-schedule div.wcb-session-favourite-icon a.fav-session-button:focus {
	color: #aaa;
}

I think this is enough for now to solve this issue and before you make a revamp of the feature or make it look nicer (which I totally agree it's something we should do). Please test it (we're probably adding this code to our custom CSS in WCEU site, but it happens also in other sites like Porto and Vigo) and feel free to modify the CSS and deploy it. Thanks!

@renintw renintw added the [Type] Story Composed of multiple features, enhancements, or bug fixes that deliver clear user value label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Blocks All custom blocks (Speakers, CrowdCast, Live Schedule, etc) [Type] Bug [Type] Enhancement [Type] Feature Request [Type] Story Composed of multiple features, enhancements, or bug fixes that deliver clear user value
Projects
Status: 🛑 Pending discussion
Development

No branches or pull requests

2 participants