Inconsistent dropdown content

[renintw]

Describe the bug

Based on other dropdowns and other latest themes, the title shouldn't be there inside the dropdown.

Expected behavior

Remove the text 'Format'.

Screenshots / Screencasts

[ryelle]

It looks like "Format" is a single-select, which intentionally has a different look/behavior to it — the visible title and lack of clear button (#1293) are intentional here. See WordPress/pattern-directory#648 (comment). You can see the same behavior on Showcase & Patterns:

[renintw]

Thank you for sharing the rationale behind this! Feel that a single-select isn't suitable here because sorting doesn't filter out content, yet the Format reduces the visible content. Users would likely want to clear the filter. Or alternatively, like on Patterns, we could also add an "All" option and set it as the default.

[pkevan]

Thank you for sharing the rationale behind this! Feel that a single-select isn't suitable here because sorting doesn't filter out content, yet the Format reduces the visible content. Users would likely want to clear the filter. Or alternatively, like on Patterns, we could also add an "All" option and set it as the default.

I was just about to comment to say the same thing 😄

[pkevan]

I think we can get the same All option like patterns by using the filter: https://github.com/WordPress/pattern-directory/blob/trunk/public_html/wp-content/themes/wporg-pattern-directory-2024/inc/block-config.php#L13.

[ryelle]

Yep, these options are set up here:

wordcamp.org/public_html/wp-content/themes/wporg-events-2023/inc/events-query.php

Lines 445 to 470 in 3d425fd

	function get_format_type_options( array $options ): array {
	$facets = get_query_var_facets();
	$selected = $facets['format'] ?? array();
	$count = count( $selected );
	$label = __( 'Format', 'wporg' );
	if ( $count > 0 ) {
	$label = sprintf(
	/* translators: The dropdown label for filtering, %s is the selected term count. */
	_n( 'Format <span>%s</span>', 'Format <span>%s</span>', $count, 'wporg' ),
	$count
	);
	}
	return array(
	'label' => $label,
	'title' => __( 'Format', 'wporg' ),
	'key' => 'format_type',
	'action' => build_form_action_url(),
	'options' => array(
	'online' => 'Online',
	'in-person' => 'In Person',
	),
	'selected' => $selected,
	);
	}

So you can add an "All" option there.