Replace 'country_of_residency' with 'passport_issuing_country' #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renintw
added
[Component] Docs
|
@WordPress/community-admins Do you have any thoughts on the replacement of words here? There's already PR for it and it looks reasonable. |
|
This makes total sense to me and sounds like an improvement useful for all visa letters of all WP events. |
The 'country_of_residency' field in both 'speaker-visa.php' and 'attendee-visa.php' templates has been changed to 'passport_issuing_country'. This more accurately represents the data input and provides clearer information about where the passport was issued.
The translation function has been upgraded from `_e` to `esc_html_e` to enhance security and accuracy in the form labels across 'sponsorship-agreement.php' and 'speaker-visa.php' files. This small but critical change is aimed at preventing potential security threats while ensuring the correct display of translated strings.
The `_e` translation function used in the sponsorship agreement form has been replaced with `esc_html_e`. This improves the security and correctness of translated strings in 'sponsorship-agreement.php'. The change is aimed at mitigating potential security threats and ensuring accurate display of translated text.
The `_e` translation function used in the sponsorship agreement form has been replaced with `esc_html_e`. This improves the security and correctness of translated strings in 'sponsorship-agreement.php'. The change is aimed at mitigating potential security threats and ensuring accurate display of translated text.
renintw
force-pushed
the
1277_Passport-Issuing-Country
branch
from
1cf1d74
to
31e7d24
Compare
renintw
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'country_of_residency' field in both 'speaker-visa.php' and 'attendee-visa.php' templates has been changed to 'passport_issuing_country'. This more accurately represents the data input and provides clearer information about where the passport was issued.
Fixes #1277
Props pbearne shawnhooper