Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezones where dates are displayed. #77

Closed
StevenDufresne opened this issue Mar 11, 2020 · 3 comments
Closed

Add timezones where dates are displayed. #77

StevenDufresne opened this issue Mar 11, 2020 · 3 comments

Comments

@StevenDufresne
Copy link
Contributor

We should add the local timezone and its offset where we display dates:

Ie: ...9:00 pm KST(UTC+9)

Locations:

  • Modal window
  • List item
  • Shortcodes

I don't think we need it on the button in the calendar view.

Notes:

  • Don't forget about things like CST and CDT
@StevenDufresne
Copy link
Contributor Author

It doesn't appear like we can consistently support adding the local timezone KST.

It was removed from moment.js and we need the timezone (America/Los_Angeles) to run abbreviations with moment timezone

@StevenDufresne
Copy link
Contributor Author

@tellyworth @ryelle @dd32

Does this work?

calendar
list

@dd32
Copy link
Member

dd32 commented Mar 12, 2020

@StevenDufresne That looks good to me within the limitations of JS timezone support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants