Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block audit: List #8237

Closed
7 of 13 tasks
sarahmonster opened this issue Jul 26, 2018 · 2 comments
Closed
7 of 13 tasks

Block audit: List #8237

sarahmonster opened this issue Jul 26, 2018 · 2 comments
Assignees
Labels
[Block] List Affects the List Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@sarahmonster
Copy link
Member

sarahmonster commented Jul 26, 2018

Note: We'll be doing these audits in waves and editing this as we work through the blocks, so this text will be updated and fleshed out as we progress. See the full picture here.

Overview

screenshot 2018-07-26 19 37 34

Name: List
Description: Numbers, bullets, up to you. Add a list of items.
Category: Common blocks
CSS class: none in frontend or editor
Can be converted to: paragraph, quote

States

Empty:
screenshot 2018-07-26 19 35 11

Selected:
screenshot 2018-07-26 19 35 46

Unselected:
screenshot 2018-07-26 19 35 53

Placeholder:
screenshot 2018-07-26 19 35 21

Primary (toolbar) settings

Bulleted, numbered, decrease indent, increase indent, bold, italic, strikethrough, link

Secondary (sidebar) settings

Advanced: Additional CSS Class

Frontend appearance

Gutenberg starter theme:

screen shot 2018-07-31 at 1 57 39 pm

Atomic Blocks

screen shot 2018-07-31 at 1 53 03 pm

twentyseventeen:

screen shot 2018-07-31 at 2 28 59 pm

twentyten:

screen shot 2018-07-31 at 2 27 35 pm

Bugs/errors

Individual issues will be opened for these soon

  • Empty <br> tags appear at the end of list items. (Cannot reproduce with WP 5.0.3 — @kjellr)

  • Regardless of whether I'm using bulleted or numbered lists, the bulleted option is always selected in the primary toolbar. (Cannot reproduce with WP 5.0.3 — @kjellr)

  • Using sibling inserter before a list block doesn't seem to work properly. (May be a sibling inserter issue.)(Cannot reproduce with WP 5.0.3 — @kjellr)

  • Issues related to using tabs to control indentation. (Indent list keyboard shortcuts inconsistencies #7051)

Suggestions

Individual issues will be opened for these soon

@sarahmonster sarahmonster created this issue from a note in The Great Block Audit of 2018 (To do) Jul 26, 2018
@sarahmonster sarahmonster self-assigned this Jul 26, 2018
@sarahmonster sarahmonster added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Blocks Overall functionality of blocks labels Jul 26, 2018
@sarahmonster sarahmonster moved this from To do to In progress in The Great Block Audit of 2018 Jul 26, 2018
@kjellr kjellr moved this from Needs frontend screenshots to Needs mobile check in The Great Block Audit of 2018 Jul 31, 2018
@sarahmonster sarahmonster moved this from Needs mobile check to Needs accessibility check in The Great Block Audit of 2018 Aug 8, 2018
@sarahmonster sarahmonster moved this from Needs accessibility check to Needs documentation review in The Great Block Audit of 2018 Aug 8, 2018
@dionysous
Copy link

I wrote an issue about another bug which happens when pasting multiline text into the list: #9476

@designsimply designsimply added the [Block] List Affects the List Block label Oct 16, 2018
@karmatosed karmatosed moved this from Need issues filing to Being made into issues in The Great Block Audit of 2018 Feb 25, 2019
@sarahmonster
Copy link
Member Author

All issues here have been filed as individual issues, so I'm going to go ahead and close out this tracking bug. Feel free to comment on if I missed anything, or open new issues as needed! 💪

The Great Block Audit of 2018 automation moved this from Being made into issues to Done Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
No open projects
Development

No branches or pull requests

3 participants