Dedupe packages #61532
Merged
Dedupe packages #61532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -10 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
sirreal
added
the
[Type] Task
sirreal
force-pushed
the
fix/dedupe-packages
branch
from
3c88ba3
to
bd4013c
Compare
|
It would be nice to make it harder to get into this state. Generally we don't want package duplication if we can avoid it. |
This was referenced May 10, 2024
Merged
gziolo
approved these changes
May 10, 2024
I think there's a few options. If we want this to happen automatically, it seems we can add If we want it to be more intentional, we could create an audit workflow that runs I think I prefer the first option, but there may be some consequences of changing the strategy that are not immediately apparent. |
|
Nice @desrosj! I think |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Dedupe JavaScript dependencies.
Why?
Reducing dependency duplication is beneficial in general:
This will likely make it easier to upgrade certain packages in the future.
This will be helpful for #61486
How?
Run
npm dedupeuntil it no longer changes the package-lock.json file.Fix resulting test errors.
Testing Instructions
Automated testing should be sufficient here.