Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns Page: Routing issue #61172

Open
t-hamano opened this issue Apr 27, 2024 · 2 comments
Open

Patterns Page: Routing issue #61172

t-hamano opened this issue Apr 27, 2024 · 2 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Apr 27, 2024

Reported in this comment

Description

From what I understand, there are two issues with the pattern page in the latest version of Gutenberg:

  • Previously selected category is not selected when returning to the Patterns page from the Pattern details page.
  • When clicking on a pattern in the data view, the editor canvas opens instead of going through the Pattern details page.

This may be a regression that occurred during the refactoring process of the pattern page or template parts page.

Step-by-step reproduction instructions

  • Access Appearance > Editor.
  • Create a pattern.
  • Click "My patterns".
  • Click the pattern.
  • Click on the pattern you just created.
    • Expected (WP6.5): The Pattern details page opens.
    • Actual (Latest Gutenberg): The editor canvas opens.
  • Click on the logo in the upper left to open the Pattern details page.
  • Click the back button.
    • Expected (WP6.5): "My patterns" is selected.
    • Actual (Latest Gutenberg): "All patterns" is selected.

Screenshots, screen recording, code snippet

5bf17510002d4871c34089d0347d32d3.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Apr 27, 2024
@t-hamano
Copy link
Contributor Author

Looking back through the commits, it appears that this issue was caused by #60466.

On the pattern details page, the URL is wp-admin/site-editor.php?postType=wp_block&postId=1&categoryId=my-patterns&categoryType=pattern.

image

When you press the back button, everything except the path is removed from the URL and it changes to wp-admin/site-editor.php?path=%2Fpatterns.

image

@t-hamano
Copy link
Contributor Author

Previously selected category is not selected when returning to the Patterns page from the Pattern details page.

This issue was resolved in #61174.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant