Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Workflow: cherry picking gutenberg.php changes into trunk can cause the workflow to fail due to merge conflicts. #61151

Open
vcanales opened this issue Apr 26, 2024 · 0 comments
Labels
[Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling

Comments

@vcanales
Copy link
Member

Description

During the release of Gutenberg 18.2, @colorful-tones ran into an issue where the
"Cherry-pick the version bump commit to trunk" step failed due to a merge conflict, caused by changes to gutenberg.php that were commited to trunk after the release of 18.2 RC1, and were not incorporated into the release branch as they were not labeled.

I think there are at least a couple of options for making sure that any changes to gutenberg.php are incorporated to the release branch before cherry picking it into trunk:

  1. Automatically labeling changes to gutenberg.php so that they're cherry picked into the release candidate before the stable workflow is run.
  2. Modifying the workflow so that changes to the file are pulled automatically.

Step-by-step reproduction instructions

I suggest trying this in a fork:

  1. Run a new release candidate workflow.
  2. Modify gutenberg.php in trunk.
  3. Run a stable release workflow.

The process will fail due to a merge conflict in gutenberg.php.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@vcanales vcanales added the [Type] Build Tooling Issues or PRs related to build tooling label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

No branches or pull requests

1 participant