Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper Inserter block title text wrapping #61125

Closed
richtabor opened this issue Apr 25, 2024 · 2 comments · Fixed by #61137
Closed

Improper Inserter block title text wrapping #61125

richtabor opened this issue Apr 25, 2024 · 2 comments · Fixed by #61137
Assignees
@afercia
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

richtabor commented Apr 25, 2024 •
edited

The word-break: break-all applied to .block-editor-block-types-list__item-title is causing block titles to break mid-word. This is a regression from #60890.

The words should be readable.

Visual

CleanShot 2024-04-25 at 18 00 10
@richtabor richtabor added [Type] Bug An existing feature does not function as intended [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Apr 25, 2024
@richtabor
Copy link
Member Author

Thoughts @afercia?

@afercia
Copy link
Contributor

afercia commented Apr 26, 2024

Hmm thanks for the ping @richtabor I noticed this yesterdya as well but didn't dive into it.

I assumed the Truncate component was mainly used to truncate text in one line. I do realize it can be used also for text in multiple lines e.g. <Truncate numberOfLines={ 3 }>. Will look into it, thinking to add the break-all only when numberOfLines is 1 could work.

@afercia afercia self-assigned this Apr 26, 2024
@afercia afercia mentioned this issue Apr 26, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 26, 2024
@richtabor richtabor mentioned this issue May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afercia afercia

Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Truncate component for long unbreakable text. WordPress/gutenberg
2 participants
@afercia @richtabor