Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint rule for lambda parameters #611

Closed
nylen opened this issue May 2, 2017 · 3 comments · Fixed by #6264
Closed

Add eslint rule for lambda parameters #611

nylen opened this issue May 2, 2017 · 3 comments · Fixed by #6264
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Build Tooling Issues or PRs related to build tooling [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone

Comments

@nylen
Copy link
Member

nylen commented May 2, 2017

Which should we prefer?

const func = param => value;

or

const func = ( param ) => value;

I personally prefer the first style, but either way I think we should codify this into a lint rule.

@nylen nylen added [Type] Build Tooling Issues or PRs related to build tooling [Type] Task Issues or PRs that have been broken down into an individual action to take labels May 2, 2017
@aduth
Copy link
Member

aduth commented May 2, 2017

My vote would be toward the second, for consistency and ease of maintenance when adding additional arguments.

@BE-Webdesign
Copy link
Contributor

I second aduth's statement, even though I usually use the top style.

@aduth aduth added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label May 26, 2017
@dmsnell
Copy link
Contributor

dmsnell commented Jun 14, 2017

My vote is for the first with @nylen, but can I also vote to allow either?

How about we just use Reason/OCaml? No more parentheses!

@karmatosed karmatosed added this to the Merge Proposal milestone Jan 25, 2018
@aduth aduth self-assigned this Feb 8, 2018
@aduth aduth removed their assignment Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Build Tooling Issues or PRs related to build tooling [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants