Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom-out can trigger double scrollbars in the editor canvas. #61093

Open
youknowriad opened this issue Apr 25, 2024 · 2 comments · May be fixed by #61548
Open

Zoom-out can trigger double scrollbars in the editor canvas. #61093

youknowriad opened this issue Apr 25, 2024 · 2 comments · May be fixed by #61548
Assignees
Labels
[Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@youknowriad
Copy link
Contributor

Description

Double scrollbars are visible in the editor canvas when you scroll while zoom-out mode is active.

Step-by-step reproduction instructions

If you're on MacOS, make sure to have the "scrollbars always visible" setting active.

1- Enable the zoom-out mode experiment.
2- Go the site editor.
3- Edit the home page of 2024.
4- Trigger the zoom-out mode.
5- Notice that if you scroll in the canvas, you'll start seeing two scrollbars. And on Safari, they persist even after leaving zoom-out mode.

Screenshots, screen recording, code snippet

Screenshot 2024-04-25 at 7 05 00 AM

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Feature] Zoom Out labels Apr 25, 2024
@mikachan
Copy link
Member

mikachan commented May 9, 2024

I don't think this is related to zoom-out, or it's at least not only triggered by zoom-out mode, as I can reproduce this with the inserter as well:

image image

The outer scrollbar is from a NavigableRegion with interface-interface-skeleton__content class. The inner scrollbar is from the editor canvas iframe. I would guess we want to prioritise the scrollbar from the iframe, as that should be the true height of the content we want to scroll.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 10, 2024
@ntsekouras
Copy link
Contributor

👋 - It would be great if you can test this PR to see if it fixes the issue you're mentioning here, because I couldn't reproduce your use case, but I've found a double scrollbar issue.. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Development

Successfully merging a pull request may close this issue.

3 participants