Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE: try and expand inline boundaries to more elements #459

Closed
jasmussen opened this issue Apr 20, 2017 · 4 comments
Closed

TinyMCE: try and expand inline boundaries to more elements #459

jasmussen opened this issue Apr 20, 2017 · 4 comments
Assignees
Projects

Comments

@jasmussen
Copy link
Contributor

In #207 which is on track to ship with WordPress 4.8 in May, TinyMCE will add an inline boundary feature for links and code, which you can test here: https://wordpress.github.io/gutenberg/tinymce/

This is a good first step. But we should explore also adding the inline boundary feature to b, i, em, strong, del, ins.

We might find this is not desirable as those elements tend to be nested. But we should absolutely try it at least in prototype form, and see how it survives complex markup.

@jasmussen jasmussen added this to To Do in Ephox Team Apr 20, 2017
@spocke spocke self-assigned this Apr 24, 2017
@BoardJames BoardJames moved this from To Do to In Progress in Ephox Team Aug 1, 2017
@spocke spocke moved this from In Progress to Done in Ephox Team Aug 31, 2017
@spocke
Copy link

spocke commented Aug 31, 2017

This has been fixed and a new option that allows you to expand the default list of elements to other things than just code and links. If this is a good idea from a UX standpoint is another question. :)
https://www.tinymce.com/docs/configure/content-appearance/#inline_boundaries_selector

@spocke spocke closed this as completed Aug 31, 2017
@androb
Copy link
Contributor

androb commented Oct 9, 2017

This has not been tried in Gutenberg yet AFAIK.

Re-opening this issue and assigning to a James to create a "TRY" branch for.

You can view the interaction at this CodePen: https://codepen.io/tinymce/live/EwLYBM

@androb androb reopened this Oct 9, 2017
@androb androb assigned anna-harrison and BoardJames and unassigned spocke Oct 9, 2017
@BoardJames
Copy link

PR open in #2947

@BoardJames
Copy link

Should now be fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

5 participants