Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks on logins #302

Open
joho1968 opened this issue Jul 12, 2023 · 2 comments
Open

Hooks on logins #302

joho1968 opened this issue Jul 12, 2023 · 2 comments

Comments

@joho1968
Copy link

It'd be nice if the loginAction() function would always call one of two hooks (if set, of course); one for a successful login attempt and one for a failed login attempt.

@robiso
Copy link
Collaborator

robiso commented Nov 1, 2023

When discussing this with Slaven, we did not want to open ourselves to any additional attack vectors of letting anyone trying to bruteforce your website with success/fail messages (other than the current lightweight alert).

@joho1968
Copy link
Author

joho1968 commented Nov 6, 2023

Well, this could actually be used to improve the site security in a plugin (for example). I've written security plugins for WordPress that utilize hooks to communicate with fail2ban to make brute-force attacks much harder. One could also easily implement login throttling if these hooks were present, as well as 2FA.

The hooks won't be doing anything unless something, well, hooks them 😎

Just my two cents 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants