Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could renderPageNavMenuItem() be made public, or injectable? #297

Open
joho1968 opened this issue May 31, 2023 · 0 comments
Open

Could renderPageNavMenuItem() be made public, or injectable? #297

joho1968 opened this issue May 31, 2023 · 0 comments

Comments

@joho1968
Copy link

Looking at modifying the way the menu is created (or rather, the HTML portion of it), I see that renderPageNavMenuItem() is marked as private, thus making it hard to change the rendered output of the public method menu().

It would be nice if this was somehow made injectable or configurable, i.e. what CSS classes are added for the LI and A elements, for active/current elements, and non-active, etc.

(This becomes a real issue when using Bootstrap 5 since the active CSS class is set on the A element, rather than the LI element.)

Just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant