Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle injection into / overflow of the current outgoing packets buffer #446

Open
Byrth opened this issue May 22, 2021 · 0 comments
Open

Comments

@Byrth
Copy link
Contributor

Byrth commented May 22, 2021

If an addon developer injects a chunk in the outgoing packet event, the chunk will appear in the next of outgoing packet. This causes 400~500ms of latency and makes some order-dependent usages impossible.

It should instead be appended to the current outgoing packet buffer.

This, of course, implies that overflows need to be handled. Order of packets can be important, so overflow handling would need to maintain the order and not (for instance) get appended to the end of the subsequent packet. As far as how important it is to properly handle overflows, my memory is that the outgoing packet buffer is almost never filled up, but that gearswap pushes users a lot closer than they could possibly get on their own. I think we did the math and 2 big equipset + action + standard outgoing client packet gets pretty close to full.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant