Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon] [findAll] Server-specific files #2313

Open
Byrth opened this issue Aug 28, 2023 · 3 comments
Open

[Addon] [findAll] Server-specific files #2313

Byrth opened this issue Aug 28, 2023 · 3 comments

Comments

@Byrth
Copy link
Contributor

Byrth commented Aug 28, 2023

Right now findAll dumps inventory data into findAll/data/${character_name}.lua. However, it is possible for players to have the same character name on two servers.

It should instead use both server_name and character_name in the path or filename.

Pretty trivial change (windower.ffxi.get_info()['server'] + resources.servers to translate it), but it would invalidate existing files for people.

@Nifim
Copy link
Contributor

Nifim commented Aug 28, 2023

You could add a fall back to the original path, in the event findAll/data/${server_name}_${character_name}.lua does not exist look for findAll/data/${character_name}.lua and then only save to the new path.

@RubenatorX
Copy link
Collaborator

RubenatorX commented Aug 28, 2023

Pretty trivial change (windower.ffxi.get_info()['server'] + resources.servers to translate it), but it would invalidate existing files for people.

This approach will cause errors on private servers without additional consideration (specifically that, on a private server, windower.ffxi.get_info()['server'] would typically return nil, so make sure to handle that case)

@lili-ffxi
Copy link
Contributor

Keeping it private-server friendly, and backwards compatible, would just be a matter of making it fallback to Charactername.lua if Server_Charactername.lua is not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants