Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config lib overwrites global settings when using lists or sets #1916

Open
xurion opened this issue Aug 8, 2020 · 2 comments
Open

Config lib overwrites global settings when using lists or sets #1916

xurion opened this issue Aug 8, 2020 · 2 comments

Comments

@xurion
Copy link
Contributor

xurion commented Aug 8, 2020

When using the config lib to store a list or set (using S{} or L{}) the global settings are overloaded after reloading an addon and modifying settings.

You can easily reproduce this issue with the Autojoin addon:

  1. Remove settings.xml if it already exists for Autojoin.
  2. Load Autojoin.
  3. Add to the whitelist with //autojoin whitelist add xurion. The settings.xml file will look ok at this point.
  4. Reload Autojoin.
  5. Add a second entry on to the whitelist.

The <global> in settings.xml will now be polluted with incorrect settings that will now be applied to all other characters.

@RubenatorX
Copy link
Collaborator

RubenatorX commented Aug 8, 2020

this is not a problem with the config lib, Its a problem with the addon. It needs to be re-loading settings on login, and its not doing that.

@RubenatorX
Copy link
Collaborator

Actually I'm wrong, it definitely decides to add some of the settings to global, not sure why will chat with someone about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants