Skip to content
This repository has been archived by the owner on Feb 11, 2023. It is now read-only.

Make build.js configurable via environment variables #38

Open
pldimitrov opened this issue Jun 20, 2019 · 1 comment
Open

Make build.js configurable via environment variables #38

pldimitrov opened this issue Jun 20, 2019 · 1 comment

Comments

@pldimitrov
Copy link

pldimitrov commented Jun 20, 2019

The current setup is not very automation-friendly. The only way to drive this from CI without baking the configuration (and secrets) into the source code is to do something like:

  • generate a distribution with a dummy confiig.json that contains only placeholders
  • have CI replace the placeholders with values coming from environment variables
  • generate a new zipfile (duplicating the logic from function zip(files))

or craft a string with the parameters you need and feed it to build.sh via stdin, but that is even hackier, I guess.

@tuomovee
Copy link

tuomovee commented Mar 1, 2021

Please check out my PR #84 when you have time. Cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants