Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent add-on from breaking when Facebook updates #55

Open
WesleyBranton opened this issue Aug 19, 2022 · 1 comment
Open

Prevent add-on from breaking when Facebook updates #55

WesleyBranton opened this issue Aug 19, 2022 · 1 comment
Labels
enhancement New feature or request P2 This issue is considered high priority

Comments

@WesleyBranton
Copy link
Owner

Currently, changes to Facebook frequently break some or all of the add-on's functionality. This is because the framework that Facebook uses appears to use randomly generated classes and IDs, which seem to change often and breaks the CSS that the add-on is using.

If possible, it would be cool if there was a better way to deploy CSS changes to the add-on or, better yet, a way to prevent the add-on from breaking when there are changes.

@WesleyBranton WesleyBranton added enhancement New feature or request P2 This issue is considered high priority labels Aug 19, 2022
@h7io
Copy link

h7io commented Oct 4, 2022

So you can match the HTML elements a bit more reliably by searching for the aria-label properties. For example, the reactions on posts have aria-label="See who reacted to this" on the English localization, so a css rule span[aria-label="See who reacted to this"] {} would match it.
But it is a bit too "inner" and does not match everything needed. A few parent DIVs would be better off to be removed, but since CSS does not have a parent selector - I imagine it could only be implemented with JS traversal, i.e. search by the aria first and then go up the hierarchy to remove the parents.
And also, it is localization-specific, so some way to gather all the localized aria texts would be needed.

Regardless, great add-on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 This issue is considered high priority
Projects
None yet
Development

No branches or pull requests

2 participants