New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static Ethernet settings not shown #3079
Comments
@adioanca-rpma Thanks very much for taking the time to look into this. Would you be willing to put together a pull request with your proposed patch? Thanks |
Done. @benfrancis @tim-hellhake could you please help with NodeJS 16 build tools docker image? Thank you |
Another thing that I observed was that if one presses My solution was to add this to
If you want this fix or have a better solution, please let me know. Thanks |
@adioanca-rpma I don't have another suggestion, no, but please feel free to file a separate issue for that. I've just noticed that I can't reproduce the bug about static Ethernet settings not being shown in WebThings Gateway 1.1 on a Raspberry Pi, where it seems to work fine. I don't have the current master branch installed on a platform which supports network settings so I can't test that. Can you confirm which platform you're running on when you experience this bug so that I can try to reproduce it? Is it Raspberry Pi? I find it odd if this is a regression between 1.1 and master because as far as I'm aware this code hasn't been touched. Thanks |
yes, RPi. I can reproduce it. branch/commit:
I've just retested now. To reproduce, try realoading the browser page while in Network (and/or Ethernet page). If you have a static configuration you won't see any of the 3 fields. Note that once you've changed from dhcp to static, you'll be redirected to network page, and if you go into Ethernet page again - the fields will be visible. And if you change to dhcp, the static fields will remain visible - although they shouldn't. Try playing static<->dhcp, Network<->Ethernet screens, back and forth and you'll see the issues. Remember to also play with browser page reload. ... also search the master branch for gateway/static/js/views/settings.js Line 876 in 627c7c4
d typo and it's the only place in the project where it appears - which means a static IP is never shown. I don't understand how it works for you... are you seeing the static IP that you have configured? what about after browser page reload or GW restart?
|
gateway/static/js/views/settings.js
Line 876 in 4dadba9
Issues:
ipdaddr
instead ofipaddr
.options
is missing. should bebody.options.[ipaddr | netmask | gateway]
ipaddr| netmask| gateway
should be''
andthis.elements.network.client.ethernet.netmask.value = '255.255.255.0';
line be removed IMO.also the elements are hidden so my ugly workaround was to add:
in
setupNetworkElements
andin
showEthernetSettings
which now looks like this:The text was updated successfully, but these errors were encountered: