Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Magewire; allow route exclusions #12

Open
rhoerr opened this issue Apr 17, 2023 · 0 comments
Open

Incompatible with Magewire; allow route exclusions #12

rhoerr opened this issue Apr 17, 2023 · 0 comments

Comments

@rhoerr
Copy link

rhoerr commented Apr 17, 2023

This is a really helpful module, but the comments it adds to output can cause problems for some JS and other systems.

One in particular is Magewire, which relies on one parent node in the HTML sections.

I suggest adding a setting to exclude controller routes or URLs from processing, so that we could have this module enabled except on requests to magewire/, or my/custom/ajax, or other routes as appropriate.

An alternative might be stripping top-level comments from output, but that would certainly cause other issues, and wouldn't necessarily solve all incompatibilities either.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant