Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Utilize LibDBIcon's API for AoC Menu #4453

Open
StormFX opened this issue May 10, 2023 · 4 comments
Open

Feature Request: Utilize LibDBIcon's API for AoC Menu #4453

StormFX opened this issue May 10, 2023 · 4 comments
Assignees
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.

Comments

@StormFX
Copy link
Sponsor

StormFX commented May 10, 2023

Is your feature request related to a problem? Please describe.

Currently, the WA menu button in the add-on compartment can't be disabled. This can potentially cause taint. Additionally, the tooltip covers the menu.

Describe the solution you'd like

Allow the middle-mouse to cycle between no icon, the minimap icon or the add-on compartment, as having one of the latter two enabled makes the other redundant.

An alternative (and better) solution would be to use LibDBIcon-1.0's updated API to handle registering and unregistering the AoC button and tooltip. This allows a simpler method of handling the placement options while also solving the issue with the tooltip.

Describe alternatives you've considered

N/A

Additional context

Current:
image

Using LibDBIcon (Masque):
image

Edit: I may be wrong, but I believe LibDBIcon anchors the tooltip to the button itself, vs the AoC frame.

@StormFX StormFX added the 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature. label May 10, 2023
@Stanzilla
Copy link
Contributor

Yeah I think a tri-state dropdown would be the best here. One day I will have to code up the default settings panel...

@StormFX
Copy link
Sponsor Author

StormFX commented May 10, 2023

You mean something besides just the aura management panel with some buttons on the frame? :p Could add a "Settings" tab and clean up the main panel a bit.

@Stanzilla
Copy link
Contributor

You mean something besides just the aura management panel with some buttons on the frame? :p Could add a "Settings" tab and clean up the main panel a bit.

basically this

@StormFX
Copy link
Sponsor Author

StormFX commented May 10, 2023

I'm looking to do something similar with Masque, just going to take a lot of work. I'm wanting to do something similar to the work order frame, but will have to look into keeping it Classic-friendly. In any case, I'm sure whatever you come up with will be awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants