Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a means for an aura to detect if it's not loaded #4262

Open
emptyrivers opened this issue Jan 20, 2023 · 4 comments
Open

Provide a means for an aura to detect if it's not loaded #4262

emptyrivers opened this issue Jan 20, 2023 · 4 comments
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.

Comments

@emptyrivers
Copy link
Contributor

yes, i know this makes no sense but hear me out ok?

This is mainly useful for preventing unwanted side effects. Consider, for example, a WA which acts as a replacement for the players's cast bar. It might be reasonable to have such a WA unregister all events & hide the builtin cast bar in init action. The problem here is that if you open options and click on this WA to edit it, the init action will execute and disable the builtin cast bar, whether the user wants it to or not. Now, the author has suddenly created a landmine for their users, where every time they go to edit something, they might have to reload their ui to undo changes they explicitly asked not to happen.

Now, this is in principle avoidable today thru careful use of WeakAuras.IsOptionsOpen(), but honestly is kind of a headache. We could refuse to run any custom code on an unloaded aura, but this could have unwanted results for auras which /could/ load later in the session (eg in combat). So, it seems to me that we should inform the author when their code is running in "preview" mode, but isn't actually loaded.

Or, perhaps we should just tell authors to be more responsible with the code they write, idk.

@emptyrivers emptyrivers added the 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature. label Jan 20, 2023
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Jan 20, 2023
@InfusOnWoW
Copy link
Contributor

Well, maybe OnLoad and OnUnload script handlers?

@emptyrivers
Copy link
Contributor Author

heh, this isn't the first time I've brought this up i see (#223), though at the time I was thinking of a different use case

@emptyrivers emptyrivers removed the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Mar 22, 2024
@mrbuds
Copy link
Contributor

mrbuds commented May 28, 2024

@alexchopstix this ticket is not about auras visibility.

@alexchopstix
Copy link

alexchopstix commented May 28, 2024

@alexchopstix this ticket is not about auras visibility.

Yes I know that. Nevermind I'm just deleting that comment because it's just going to confuse people. All of the answers for these types of issues all end up pointing to the creator of said WeakAura. And it's not like I don't disagree they should be making their WeakAuras with these things in mind but they don't. And I'm not gonna go create a whole custom WA myself when there's one out there, it's just that editing them is a pain in the ass.

Is what it is though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.
Projects
None yet
Development

No branches or pull requests

4 participants