Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embedded ICC color profile #31

Open
o-l-a-v opened this issue Jan 31, 2024 · 3 comments
Open

Support embedded ICC color profile #31

o-l-a-v opened this issue Jan 31, 2024 · 3 comments
Labels
bug Something isn't working feature

Comments

@o-l-a-v
Copy link
Contributor

o-l-a-v commented Jan 31, 2024

It seems CactusView does not yet support viewing images with embedded ICC color profile properly. I tested with both JPG and PNG.

Test image source:

Test images transcoded by me:

JPEG example

Sample image can be transcoded to JPG with ICC profile using libjxl ( https://github.com/libjxl/libjxl/releases/tag/v0.9.1 ) like so:

  • With XYB: ".\libjxl-v0.9.1\cjpegli.exe" ".\forest.jxl" ".\forest_xyb.jpg" --quality=90 --xyb --chroma_subsampling=444
  • Without XYB: ".\libjxl-v0.9.1\cjpegli.exe" ".\forest.jxl" ".\forest.jpg" --quality=90 --chroma_subsampling=444

Result in CactusView vs. GIMP

Using XYB

240131 - CactusViewer - JPEG with ICC color profile XYB

Not using XYB

240131 - CactusViewer - JPEG with ICC color profile

PNG example

Sample image can be transcoded to PNG with ICC profile using libjxl ( https://github.com/libjxl/libjxl/releases/tag/v0.9.1 ) like so:

  • ".\libjxl-v0.9.1\djpegli.exe" ".\forest.jpg" ".\forest.png"

Result CactusView vs. GIMP

240131 - CactusViewer - PNG with ICC color profile

@Wassimulator
Copy link
Owner

I will need to inspect how these things are encoded and how I should display them. I don't have much knowledge about how these are done. if you have any info or tips I'd appreciate it.

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented May 7, 2024

Cool. 😊 I don't know much about that either, sorry. Maybe the source code of other projects (viewers, decoders?) that handles ICC can be helpful.

@Wassimulator Wassimulator added feature bug Something isn't working labels May 7, 2024
@Wassimulator
Copy link
Owner

I'll take a look into it once I find the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature
Projects
None yet
Development

No branches or pull requests

2 participants