Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow language identifiers to be customized and preserved in IconResource #533

Open
Washi1337 opened this issue Mar 8, 2024 · 1 comment
Open

Allow language identifiers to be customized and preserved in IconResource #533

Washi1337 opened this issue Mar 8, 2024 · 1 comment
Labels
enhancement win32resources Issues related to AsmResolver.PE.Win32Resources
Milestone
6.0.0

Comments

@Washi1337
Copy link
Owner

Washi1337 commented Mar 8, 2024 •
edited

Problem Description

Currently, IconResource::WriteToDirectory always constructs resource directories with the language identifier 1033.

Proposal

Add Lcid properties to the classes related to icon resources, similar to how is done in VersionInfoResource (see #457).

Alternatives

None

Additional Context

No response
@Washi1337 Washi1337 added enhancement win32resources Issues related to AsmResolver.PE.Win32Resources labels Mar 8, 2024
@Washi1337 Washi1337 added this to the 6.0.0 milestone Mar 15, 2024
@caesay
Copy link

caesay commented Mar 31, 2024 •
edited

I'm attempting to replace rcedit in Velopack so I can set PE resources while running on Linux, I think this should be classified as a bug rather than an enhancement. This and #532 are the current blockers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement win32resources Issues related to AsmResolver.PE.Win32Resources
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
2 participants
@caesay @Washi1337