Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track selected group number(s) (UI) #3678

Open
past-due opened this issue Mar 9, 2024 · 1 comment
Open

Track selected group number(s) (UI) #3678

past-due opened this issue Mar 9, 2024 · 1 comment

Comments

@past-due
Copy link
Member

past-due commented Mar 9, 2024

Right now, when a group is selected we properly select all containing droids, but we don’t store / track the selected group number..

  • Add a new optional<uint32_t> uiCurrentSelectedGroupNumber (see EDIT below)
  • When a group is explicitly selected (via either keybind or the groups UI), set uiCurrentSelectedGroupNumber to the selected group number
  • When selection changes, reset uiCurrentSelectedGroupNumber if:
    • A member of the uiCurrentSelectedGroupNumber group loses selection
    • An object that isn’t in the uiCurrentSelectedGroupNumber group gains selection
    • (i.e. If the selected objects no longer encompass the entirety of the group + no others)
  • Add public function optional<uint32_t> getUICurrentSelectedGroupNumber() to retrieve the value

Optional additional UI enhancements:

  • Highlight the group button in the groups UI that is associated with the uiCurrentSelectedGroupNumber

EDIT:
Additional thoughts:

  • We could actually track which groups are fully selected (which could be more than one) PLUS a bool for whether any objects not in a group are selected, which opens up more possibilities.
    (Since it is possible to select more than one group manually right now, with the selection rect. And I could see where it would be useful to augment the groups UI to allow selecting more than one group concurrently as well.)
@past-due past-due changed the title Track selected group number Track selected group number (UI) Mar 9, 2024
@past-due past-due changed the title Track selected group number (UI) Track selected group number(s) (UI) Mar 9, 2024
@mirror176
Copy link

If marking that a group is fully selected, would it be helpful to be able to mark that a group is partially selected? Maybe a marker could also be made for representing ungrouped units selected. Marking multiple groups simultaneously would be more useful if all groups could be displayed at the same time instead of with a scrollbar.

Working with the new group features I still thought it would be useful to have it take less space and see all groups at once if only 1 vehicle is shown out of a mix of grouped vehicles (admittedly could be harder to tell what exact unit type with smaller models) and the color for damaged status brings up questions of if it is showing incoming damage instead or if it is 1 unit's health vs the whole group's health to cause the color to change.

Often if an RTS has a way to see a selected unit as a model on the HUD, they have a way to see multiple unit models there with each unit's health/damaged state visible at a glance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants