Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ignoring the max join length for single calls #142

Open
kmoschcau opened this issue Jan 4, 2024 · 1 comment
Open

Allow ignoring the max join length for single calls #142

kmoschcau opened this issue Jan 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@kmoschcau
Copy link

kmoschcau commented Jan 4, 2024 •
edited

Hi, I'm trying to add a forced join keymap to my config, but apparently passing a preset like this to the toggle and join methods is ignored: { max_join_length = 999 }.

I would love if I could disable the max join length feature on demand. Ideally this would be done via a separate boolean setting or setting max_join_length = 0.
@Wansmer Wansmer added the enhancement New feature or request label Jan 12, 2024
@Wansmer
Copy link
Owner

Wansmer commented Jan 12, 2024 •
edited

Hi! join and split expected a node preset. max_join_length is a global plugin option.

I added an enhancement label and will consider adding this feature for each node in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmoschcau @Wansmer