Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain verification is incorrectly generated for .it.com TLD #4471

Closed
raviriley opened this issue Apr 22, 2024 Discussed in #4451 · 7 comments
Closed

Domain verification is incorrectly generated for .it.com TLD #4471

raviriley opened this issue Apr 22, 2024 Discussed in #4451 · 7 comments
Assignees

Comments

@raviriley
Copy link

Discussed in https://github.com/orgs/WalletConnect/discussions/4451

When adding a domain with the .it.com TLD, the Verify API looks for the DNS record at it.com. This is broken and needs to be fixed.

Copy link

linear bot commented Apr 22, 2024

@raviriley
Copy link
Author

This is currently preventing anyone with a .it.com domain from using WalletConnect. Any chance a patch can be pushed ASAP similar to how .co.uk behaves?

@raviriley
Copy link
Author

@Cali93 @bkrem @glitch-txs any chance this can be patched this month? 🙏

@Cali93
Copy link
Contributor

Cali93 commented Apr 24, 2024

@raviriley Thanks for raising this. We will ship a fix in the upcoming days.

This is currently preventing anyone with a .it.com domain from using WalletConnect

Just as a clarification, it's preventing them from using Verify API, not the whole WalletConnect Protocol.

@Cali93 Cali93 closed this as completed Apr 24, 2024
@Cali93 Cali93 reopened this Apr 24, 2024
@raviriley
Copy link
Author

Awesome! You're right, thanks for the clarification 👌

@Cali93
Copy link
Contributor

Cali93 commented May 14, 2024

Hey @raviriley,

We updated our implementation and TLDs like .it.com are now parsed correctly.

Thanks for your patience 🙏

@Cali93 Cali93 closed this as completed May 14, 2024
@raviriley
Copy link
Author

Awesome, thanks @Cali93 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants