Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect WPTRT feature project versions #224

Open
justintadlock opened this issue Jul 1, 2019 · 3 comments
Open

Detect WPTRT feature project versions #224

justintadlock opened this issue Jul 1, 2019 · 3 comments

Comments

@justintadlock
Copy link

Now that we have a couple of official feature packages, we should start thinking about long-term maintenance for theme authors. If theme authors are using our packages, we want to make sure they're using the most up-to-date versions.

Having a sniff that detects this would be great. I'm not sure what all this would entail at this point, but I did want to bring it up for discussion.

It's not a high priority right now, but if we continue making other packages, I could see the need for this.

Current repos:

@dingo-d
Copy link
Member

dingo-d commented Jul 1, 2019

What would a sniff detect exactly? The version of the additions or?

Not sure I understand what should be sniffed 🙂

@justintadlock
Copy link
Author

Yes, their versions.

@dingo-d
Copy link
Member

dingo-d commented Jul 2, 2019

Hmm not 100% sure how to do that using PHPCS tho. It sniffs PHP files (JS and CSS if you tell it to), and besides the @since tags in the PHP files there is no dedicated way to check for that.

Theme Sniffer, on the other hand, can do that by just parsing the composer.json file or other files 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants