Meeting Notes 2018-07-28

[jrfnl]

FYI: for all the watchers of this repo - @dingo-d and me had a video-chat meeting today about the progress of the project. This issue is just a short summary to keep people informed.

The open PRs were briefly discussed:

• Add Theme forbidden PHP functions sniff + unit tests. #10/ Discouraged functions #124 @jrfnl is working on this, but the specs aren't clear. Will probably need a TRT decision.
• Add rule to prevent deregistering scripts. #26 @jrfnl needs to go through the notes left by @grappler and will update the PR if necessary. Once that's done, the PR needs approval & merging.
• Use capabilities not roles #36 @grappler has an open PR for this upstream. Once the upstream PR has been merged, that should be added to the ruleset instead of merging this PR.
• No Sanitize Callback #76 @jrfnl will review the sniff as it is now.
  This sniff should probably be pulled in WPCS upstream as well.
  All the same, if the sniff is ready for TRTCS, it can be merged. Once it has been merged in WPCS and the minimum supported WPCSversion in TRTCS has gone up to the version in which the sniff was merged, the TRTCS version can be removed and the ruleset adjusted to use the upstream sniff.
• Theme Restricted Parameter #80 @grappler will need to check & decide what still needs to be done.
• More common files for whitelist #104/ FileInclude: check for restricted files. #122 @jrfnl will write a summary of the current problem with these PRs as an issue for the TRT to decide upon
• Add sniff and tests for No CDN URL #108/ [New sniff] Using a CDN is discouraged #20 @dingo-d will write a summary of the current status of the PR as an issue for the TRT to decide upon.

De-forking the repo from WPCS

We discussed what steps are needed and what prerequisites need to be met/decisions need to be taken before this can be done.

• An action list of what needs to be done can be found in De-fork from WPCS #169.
  • @jrfnl will contact GH support about de-coupling this repo from WPCS.
  • A PR for this can be made relatively quickly, providing the necessary decisions are taken shortly.
• The repo will need a new name which can also be used as a PHP namespace.
  See issue Proposal: change ruleset and repo name #167 for the details of this discussion and please leave comments in that issue.
• The sniffs can be categorized in the de-forked repo. We discussed the existing Theme sniffs and suggestions for categories to use.
  See issue Proposal: new sniff categorization #166 for the details of this discussion and please leave comments in that issue.
• Once the repo is de-forked, TRTCS can also have more rulesets.
  See issue Proposal: additional rulesets #168 for the details of this discussion and please leave comments in that issue.

Issues which need to be addressed by the TRT board, will be added to the agenda for the RT meeting of August 14.

The next (video)-chat about this repo will be Saturday August 18 16:00 CET.

[jrfnl]

Oh and what I forgot to mention:

Discussed WPCS 1.0.0

• Talked through and merged PR Update to WPCS 1.0.0 #165 to update the TRTCS with the changes in WPCS.
• Talked through a few new sniffs in WPCS 1.0.0 which could be interesting for TRTCS. Proposal to add these can be found in Add sniff: WordPress.WP.EnqueuedResourceParameters #170 and Add sniff: WordPress.WP.DeprecatedParameterValues #171.