Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bikeshed ColorSpace.fromICCProfile() #34

Open
LeaVerou opened this issue Feb 15, 2023 · 0 comments
Open

Bikeshed ColorSpace.fromICCProfile() #34

LeaVerou opened this issue Feb 15, 2023 · 0 comments
Labels
api-design Issues related to API shape
Milestone
Level 2+ (Future)

Comments

@LeaVerou
Copy link
Collaborator

LeaVerou commented Feb 15, 2023 •
edited

This used to be called ColorSpace.load(), however since it's a factory method, it's good practice to start with from, for consistency. Right now I've named it fromICCProfile() though that's quite a mouthful. Maybe fromProfile() would be better? or fromFile()? Or maybe just from() and redesign its signature to take a dictionary with the ICC profile as a key?
@LeaVerou LeaVerou added the api-design Issues related to API shape label Feb 15, 2023
@LeaVerou LeaVerou added this to the Level 2+ milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-design Issues related to API shape
Projects
None yet
Milestone
Level 2+ (Future)
Development

No branches or pull requests
1 participant
@LeaVerou