Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top-level configurable #2429

Open
egonw opened this issue Feb 19, 2024 · 4 comments · May be fixed by #2485
Open

Top-level configurable #2429

egonw opened this issue Feb 19, 2024 · 4 comments · May be fixed by #2485
Assignees
Labels
enhancement some suggestions to improve Scholia

Comments

@egonw
Copy link
Collaborator

egonw commented Feb 19, 2024

Is your feature request related to a problem? Please describe.
This is related to the ongoing developments around splits and integration with the UIs for queries, like WDQS.

See also:

Describe the solution you'd like
We need in both Python and JavaScript global URLs for the following things:

  • run a SPARQL remotely and get the results table back (used for aspect tables)
  • link to the QS to embed graphics in the iframe
  • link to the QS to edit (and run) the SPARQL there

I think these three templates need to have a paramater (like $sparql) where the encoded SPARQL is embedded.

Describe alternatives you've considered
The current solution is to have these URL patterns hardcoded all over the place. This makes it hard to maintain and update Scholia for other endpoints (like Qlever).

@egonw egonw added the enhancement some suggestions to improve Scholia label Feb 19, 2024
@egonw
Copy link
Collaborator Author

egonw commented Feb 19, 2024

@fnielsen, @Daniel-Mietchen, please let me know what you think a patch to do this should take into account.

@fnielsen
Copy link
Collaborator

Yes. Long time ago we an issue or PR.

@egonw
Copy link
Collaborator Author

egonw commented Mar 2, 2024

Yes. Long time ago we an issue or PR.

@fnielsen, can you help me out? I can find the following related queries, but none capture this issue (fully):

@fnielsen
Copy link
Collaborator

fnielsen commented Apr 3, 2024

Yes. I think it would be fine with a configuration. I have previously used the config module: https://github.com/fnielsen/brede/blob/master/brede/config.py

@egonw egonw linked a pull request Apr 23, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement some suggestions to improve Scholia
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants