New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA / mobile app #405
Comments
You only have to 'install' a PWA just once, so doing it via chrome/safari for one single time, doesn't seem that big a deal. You're right, it should work wherever but I'd have to look into it. I'm not sure why it would not be recognised. |
I'd say it lacks the ability to be installed as a real app through PWA due to the missing manifest.json file. https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Installable_PWAs |
There is a manifest though 🤔 here |
mmhh manifest.22 ? what is that? I don't know if it gets recognized by browsers honestly. As said in another issue, I'm no vue dev and therefore I don't know what the vue-cli you use (I suppose) does to bundle the app |
ouch, here's the issue I suppose https://github.com/WDaan/VueTorrent/blob/master/vue.config.js#L11 :) I can confirm what I stated in my previous comment, the naming must be |
IIRC that version number was specifically added to fix an issue with webworkers not loading a new version and staying on the old one. I don't know if this ia still needed |
Exactly as I supposed. Though the fix to invalidate the cached apps relies in renaming the js and CSS assets, not the manifest file itself! |
Let's see if that new release works |
I was not aware a secure domain (https) was required. For sake of completeness I tried renaming manifest.22.json but still it didn't make any difference. (Which was what I expected since I am not using https) |
Manifest name has just been fixed, but yes.... PWA's require a valid domain with https :/ I guess this can be closed? |
Yes it can. Thanks WDaan |
Exactly, the https problem isn't this web app's issue. That's a whole other thing, but the manifest needed to be fixed. Thanks @WDaan |
VueTorrent is great but it seems it is lacking info about PWA ability.
When using mobile browser you can't create a PWA shortcuts. It doesn't matter when using a chrome browser as it would still treat it as a web app -> When using shortcut it won't show you browser interface but this not the case with Android Firefox.
So Firefox (and probably other non chrome browser) does not recognize VueTorrent as a web app. It would only allow you to have a shortcut which will open VueTorrent in browser without hiding browser UI.
It would be really nice if it was possible to implement what is missing to make it recognized as a PWA.
The text was updated successfully, but these errors were encountered: