Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention QBitTorrent #356

Closed
andrisi opened this issue Jan 2, 2022 · 14 comments
Closed

Mention QBitTorrent #356

andrisi opened this issue Jan 2, 2022 · 14 comments

Comments

@andrisi
Copy link

andrisi commented Jan 2, 2022

You do a great job with this alternative UI for QBitTorrent, but it deserves to be mentioned, and prominently. Perhaps "QBitTorrent w/Vue" or something like this, instead of just "VueTorrent" in the title and dashboard. As it is now, it's a bit unfair: you're taking credit for something that is 85% someone else's work. I could not find any obvious mention of QBitTorrent on the UI currently, and it's barely mentioned here on GitHub, for example missing from the "Credits" section.

@WDaan
Copy link
Collaborator

WDaan commented Jan 3, 2022

Thanks for taking an interest in this project.

It's literally the first sentence in the README? Also the subject of the repo.

I did not mean to offend anyone. I certainly didn't think anyone would confuse the origin of the project. As I thought VueTorrent was clearly known as an alternative WebUI, nothing more nothing less.

@andrisi
Copy link
Author

andrisi commented Jan 3, 2022

Sorry if I sounded too harsh @WDaan. You're work is great. But as it is now, for whoever I install it (friends and family for example) it looks like a tool called VueTorrent, not QBitTorrent with an alternative web interface, and this is what all users see all the time, not the readme. Perhaps "QBitTorrent" in the title, where you have "VueTorrent" now? And then "with VueTorrent" or even better "UI by WDaan" or whatever you fancy.

image

@kajover
Copy link

kajover commented Jan 12, 2022

I had the same confusion with my friends. Maybe resolve this by adding a dropdown menu like with "VueTorrent title" with the option to choose between VueTorrent and qBittorrent and something else. Alternatively, a text field could be implemented in the settings to edit the title altogether.

WDaan added a commit that referenced this issue Jan 13, 2022
@WDaan WDaan closed this as completed Jan 13, 2022
WDaan added a commit that referenced this issue Jan 13, 2022
@kajover
Copy link

kajover commented Jan 13, 2022

@WDaan, thank you a lot for your work. It is really appreciated.

The fix you implemented is a mention in the credits. It does not consider the possibility to change the title though. Should a new issue be created for the option to change the title, or can this issue be reopened again? Thank you.

@WDaan
Copy link
Collaborator

WDaan commented Jan 13, 2022

Hold your horses please. The title in the dashboard now says 'QbitTorrent'. I had messed up commits

I hope this satisfies your concern.

I'm not in favor of making the title configurable, as I don't see a real benefit to it.

@kajover
Copy link

kajover commented Jan 13, 2022

Thank you for the changes. I was about to delete my comment. Thank you! EDIT: The correct name is 'qBittorrent'

@Hukuma1
Copy link

Hukuma1 commented Jan 13, 2022

This is why this generation can't have nice things.

Thank you for your awesome alt web UI, @WDaan. Keep up the great work!

@andrisi
Copy link
Author

andrisi commented Jan 13, 2022

@Hukuma1 what are you referring to?

@kajover
Copy link

kajover commented Jan 13, 2022

@WDaan thank you for v0.15.1 - this is how it looks now:
Screen Shot 2022-01-13 at 19 51 00
Unfortunately, the tab title is not reflecting the name change to (the correct form of) 'qBittorrent'. It would be great if we had a toggle in the settings to be able to change between VueTorrent and qBittorrent. Thanks again.

@WDaan
Copy link
Collaborator

WDaan commented Jan 13, 2022

Feel free to submit a PR.

@kajover
Copy link

kajover commented Jan 13, 2022

I am not a programmer but maybe somebody else might chip in. Thank you anyway.

@WDaan
Copy link
Collaborator

WDaan commented Jan 13, 2022

Sure.

You're right, it does look a little silly if it doesn't match. Might change it to Qbittorrent as well.

Don't want to make it a setting though...there are enough Vuetorrent specific settings already.

But after that I assume it's clear enough it's an Alternative WebUI. You have to draw the line somewhere.

@kajover
Copy link

kajover commented Jan 13, 2022

v.0.15.2
Screen Shot 2022-01-13 at 20 37 12
Thanks. It's 'qBittorrent' though if you want to correct it in a future release. I can live with it though :) Thank you again.

@WDaan
Copy link
Collaborator

WDaan commented Jan 13, 2022

Damn, it's clearly been a long day...my apologies 😬😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants