Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add ability to set Share Limit by torrent #308

Closed
parsedout opened this issue Oct 16, 2021 · 9 comments · Fixed by #316
Closed

Please add ability to set Share Limit by torrent #308

parsedout opened this issue Oct 16, 2021 · 9 comments · Fixed by #316
Labels
Feature New Feature

Comments

@parsedout
Copy link

Hi, this UI is amazing but it lacks one critical feature I need for my workflow. The base qbittorrent UI allows to set the share ration limit by torrent, if you could add that to the "Set Limit -> Upload" section that would be amazing and hopefully not too difficult? Thank you for the work you put into this and keeping it maintained.

@WDaan WDaan added the Feature New Feature label Oct 16, 2021
WDaan pushed a commit that referenced this issue Nov 1, 2021
WDaan pushed a commit that referenced this issue Nov 1, 2021
@WDaan
Copy link
Collaborator

WDaan commented Nov 1, 2021

I've started with a simple share modal, that can set the ratio. Which I think is the most used.
Will add the time limit soon

@parsedout
Copy link
Author

Thank you, that works well. One issue, once you set the share limit, if you go back into to change or remove the share limit (back to infinite) it doesn't show the current share limit in the text box. Not the end of the world and it functions, but a minor bug that I thought I'd share. Appreciate this feature addition very much!

@WDaan
Copy link
Collaborator

WDaan commented Nov 3, 2021

I now have a version like this, with 2 sliders.
I believe it's the most intuitive way to get both the value/unlimitted/ use global limit inside of 1 UI component.
(As you can see, still WIP because the labels are still too small)
The only downside to using this, is that it's not very easy to use for setting time limits.... because of the big values
Let me know what you think
Screenshot 2021-11-03 at 08 56 25

@parsedout
Copy link
Author

I think the slider has potential but I agree it may be difficult. What do you think about having a text box to enter a specific value (like you have now) and next to that a radio set (or a 3 way toggle?) for use custom/override, unlimited or global limit and if one of those are selected it disables the text box? Might be a bit more intuitive? Or maybe just a text box and if the value is left null it defaults to the global limit and if you put a value in it overrides it, just that simple?

@WDaan
Copy link
Collaborator

WDaan commented Nov 3, 2021

Or maybe just a text box and if the value is left null it defaults to the global limit and if you put a value in it overrides it, just that simple?

Skipping unlimited altogether? 🤔
I think that if there's no global limit, that global limit === unlimited. But I would have to test that to confirm.

If that's the case than I wouldn't write off the slider just yet...

I can, for example, make sliding it all the way to the left show an infinite symbol & everything else it's value. For ratio I can maybe do 0.5 increments up to 5 & for time limit some smarter logic that increases the duration exponentially, e.g. 5min, 30min, 1h, 6h, 1d or something like that.

Making the whole experience a little bit more intuitive than the original UI.

@WDaan
Copy link
Collaborator

WDaan commented Nov 3, 2021

Or do the above and a toggle for unlimited that disables the slider 🤔

@parsedout
Copy link
Author

parsedout commented Nov 3, 2021 via email

@WDaan
Copy link
Collaborator

WDaan commented Nov 3, 2021

True, but 2 toggles ánd a textbox for both limits results in 6 UI components instead of 2.

Making the whole thing look more cluttered? And a cluttered UI == less intuitive, because more moving parts.

I'm by no means a UI expert 😅 so I do value others input very much

@parsedout
Copy link
Author

parsedout commented Nov 3, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants