Show connection status at the bottom of Navbar #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! First of all, thank you for contributing! It's always nice seeing people collaborate on a project. 馃檪 This PR looks great, it's a nice feature to have. Love the implementation as well, it's almost like I've written it myself 馃槢 Also, I really really appreciate the detailed analysis + screenshots... people tend to overlook those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection status icon [feat]
Hey, thanks for a great project! Some time ago I was thinking about building alternative UI using the same stack, but when I found yours it was clear enough that there is no sense doing that.
Recently I was doing some network setup changes and found this little feature to be really missing - showing if connection port is open. To check that I had to use default web UI for some time, which, you know, is not the best experience 馃槃. So here is my 5 cents and hopefully more to come.
4 icons will be shown for 4 states: connected, disconnected, firewalled and when there is no status data, with a tooltip. Hopefully the placement is ok.
Please find screenshots below (all states on desktop + mobile view):
PR Checklist