Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish Service WalkerRules #227

Merged
merged 7 commits into from Apr 19, 2021
Merged

Conversation

m4ximuel
Copy link
Contributor

@m4ximuel m4ximuel commented Apr 19, 2021

Establish Service Walker Rules [fix]

Follow the Service Walker's cache policy. It now works in offline mode if PWA is not received.

PR Checklist

  • I've started from master
  • I've only committed changes related to this PR
  • All Unit tests pass
  • I've removed all commented code
  • I've removed all unneeded console.log statements

m4ximuel and others added 6 commits April 15, 2021 13:21
…menu

fix: issue where 'torrent details' modal does not work properly on iOS
perf: 'Vue2-perfect-scrollbar' is no longer dependent
feat: checkbox with color featback for TorrentDeleteModal
perf: Context (right click) menu refactor! Works way better on mobile
@m4ximuel
Copy link
Contributor Author

#225

@WDaan
Copy link
Collaborator

WDaan commented Apr 19, 2021

I'm not sure I fully understand what's going on here?

Is this THE long awaited PWA cache fix? 😝
I'm not fully up to speed on caching & everything.

@m4ximuel
Copy link
Contributor Author

@WDaan If the service walkers are not same, it override the existing cache by new.
This operation may require closing and opening all VueTorrent pages 1-2 times depending on the environment in order to update, but this is the standard for service workers. without the work, this service worker cannot be installed as a PWA after August 2021.

@WDaan WDaan merged commit 04971dc into VueTorrent:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants