fix: application version getter #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jef
commented
Apr 18, 2021
Comment on lines
-103
to
-106
| new webpack.DefinePlugin({ | ||
| APPLICATION_VERSION: JSON.stringify( | ||
| require('./package.json').version | ||
| ) |
There was a problem hiding this comment.
This wasn't in use, so I decided to have it be in use! 😁
|
aha, so 'APPLICATION_VERSION' is known by default when building with webpack? |
|
Yep! The new webpack.DefinePlugin({
'process.env': { 'APPLICATION_VERSION': process.env['npm_package_version'] }
})Thus, webpack allows the VueJS app to view these at runtime, since they are compiled in. |
|
Awesome! thx for this fix 🙂 |
|
Thanks for the quick turn around! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: application version getter
Currently, when webpack bundles the Vue application, it no longer has access to
process.env. I've updated the webpack plugins to include this in the build and the application now has access to the value.Ref: #212
I tested putting via
npm run serveas well asnpm run buildand using it like we would in production. In both cases, seemed to be working fine!PR Checklist