Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Confirm prompt for "delete with files" #191

Closed
Ansem93 opened this issue Apr 3, 2021 · 3 comments
Closed

[Feature] Confirm prompt for "delete with files" #191

Ansem93 opened this issue Apr 3, 2021 · 3 comments

Comments

@Ansem93
Copy link

Ansem93 commented Apr 3, 2021

Hi,
I wanted to ask if it would be possibile to add a confirm prompt in case someone missclicked and use "delete with files" instead of "delete"

@m4ximuel
Copy link
Contributor

m4ximuel commented Apr 4, 2021

It's nice opinion.
It would be good to combine the delete menu of the right-click menu into one and open the delete dialog.

@Ansem93
Copy link
Author

Ansem93 commented Apr 10, 2021

Just tried the 0.8 release.
I actually thought at something different:

  • keep the delete and "delete with files" as separate button when you right click on a file
  • If you click on "delete with files" prompt a warning asking if you're sure.

Otherwise I agree with #199 ,Delete with files should be a checkbox since a button so close to "delete" is still dangerous.

@WDaan
Copy link
Collaborator

WDaan commented Apr 10, 2021

Thx for the input!
In the next release, there will be a checkbox. And the delete button changes color depending on whether it's checked or not, so it's very clear what's happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants