Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: current speed cards redesign #169

Merged
merged 1 commit into from Feb 27, 2021
Merged

feat: current speed cards redesign #169

merged 1 commit into from Feb 27, 2021

Conversation

IevgenSobko
Copy link
Contributor

Current speed cards redesign

Improvements

  • current speed cards redesign

2021-02-27__22-11-23

@IevgenSobko
Copy link
Contributor Author

Following issue #141 I created a pull request to not lost this design.
In my opinion, it is better than current and follows current conventions with rounded corners for cards in the side panel.
I have seen someone liked my pill design but it will be a little bit off the current design. Anyway, after this change, we can change to pill design by changing just one property to pill value

@WDaan
Copy link
Collaborator

WDaan commented Feb 27, 2021

First of all, thanks a lot for helping me out :)

I'm not a designer by any means but I think all properties (icon, numbers & units) should be either all horizontal or all vertical.
I personally like the first design you've made in that issue....even though there is a lot of 'wasted' space on the sides.

@IevgenSobko
Copy link
Contributor Author

All being vertical takes a lot of space as you mentioned in the issue.
So I redesigned it to take less... :)

@WDaan WDaan merged commit fa2edef into VueTorrent:master Feb 27, 2021
WDaan pushed a commit that referenced this pull request Feb 28, 2021
… of the unit in second column (#169)

Co-authored-by: Ievgen Sobko <ievgensobko@cloud.upwork.com>
@IevgenSobko IevgenSobko deleted the feat/current-speed-pills branch February 28, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants