Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torrent Detail modal with multiple tags shows only one tag selected #167

Closed
IevgenSobko opened this issue Feb 27, 2021 · 4 comments
Closed

Torrent Detail modal with multiple tags shows only one tag selected #167

IevgenSobko opened this issue Feb 27, 2021 · 4 comments
Labels
Bug Something isn't working

Comments

@IevgenSobko
Copy link
Contributor

Torrent Detail modal with multiple tags shows only one tag selected
2021-02-27__17-10-16
2021-02-27__17-10-42
@WDaan
Copy link
Collaborator

WDaan commented Feb 27, 2021

Jup, I noticed when I refactored it. There is no reason it shouldnt show them all, yet it doesnt... So I'm thinking it's an issue on vuetify component itself, but I don't know for sure

@WDaan WDaan added the Bug Something isn't working label Feb 27, 2021
@IevgenSobko
Copy link
Contributor Author

IevgenSobko commented Feb 27, 2021 •
edited

Seems it is an issue not with the component itself but how we get tags for torrent.
I've tried to debug and found it is returning extra space for every not first torrent tag.
And in the next step when we trying to get indexes of active tags to show in item-group it fails to find everything but the first tag.
2021-02-27__19-10-13
Trying to debug further to fix this.

WDaan added a commit that referenced this issue Feb 27, 2021
@WDaan
fix: Torrent Detail modal with multiple tags shows only one tag selec…
148248e 
…ted #167
@WDaan
Copy link
Collaborator

WDaan commented Feb 27, 2021 •
edited

You are right, I'm stupid 😅 I think a simple trim solves it... no clue how I didn't catch that
Feel free to confirm

@IevgenSobko IevgenSobko mentioned this issue Feb 27, 2021
Merged
@IevgenSobko
Copy link
Contributor Author

No way person wrote this whole UI is stupid 🤫

@WDaan WDaan closed this as completed Feb 27, 2021
WDaan added a commit that referenced this issue Feb 28, 2021
@WDaan
fix: Torrent Detail modal with multiple tags shows only one tag selec…
1973b5d 
…ted #167
@github-actions github-actions bot mentioned this issue Sep 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IevgenSobko @WDaan